Skip to content

Conversation

@capnrefsmmat
Copy link
Contributor

Draft blog post; submitting PR so I can preview it and tweak as needed.

@netlify
Copy link

netlify bot commented Apr 27, 2021

Deploy preview for cmu-delphi-main ready!

Built with commit c7c3457

https://deploy-preview-333--cmu-delphi-main.netlify.app

@capnrefsmmat
Copy link
Contributor Author

@sgratzl I don't think I have software to generate a WebP version of the thumbnail image for the post, and when I put in a JPG with the dimensions Chris told me long ago, the sizing comes out wrong:

Screen Shot 2021-04-27 at 4 27 56 PM

Any idea what I'm doing wrong here?

@sgratzl
Copy link
Member

sgratzl commented Apr 27, 2021

Any idea what I'm doing wrong here?

fixed

and I also added the webp version

@sgratzl sgratzl added the blog label Apr 29, 2021
@sgratzl sgratzl marked this pull request as draft April 29, 2021 13:50
@sgratzl
Copy link
Member

sgratzl commented Apr 29, 2021

@capnrefsmmat I changed this PR to be a draft, please mark it as ready once it is ready to be merged

@capnrefsmmat
Copy link
Contributor Author

Just updated the date and summary, and I think this is ready to go.

@capnrefsmmat capnrefsmmat marked this pull request as ready for review April 29, 2021 14:19
Copy link
Member

@sgratzl sgratzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from a technical view

@sgratzl sgratzl requested a review from krivard April 29, 2021 14:22
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several of the figures are illegible inline, but given the full-screen option, that's acceptable to me

@sgratzl sgratzl merged commit 4ca9b40 into dev Apr 29, 2021
@sgratzl sgratzl deleted the blog/hispanic-vaccine branch April 29, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants