Skip to content

fix pushing image tags #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2021
Merged

fix pushing image tags #301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e35ac3
ci: fix typo in push tag
sgratzl Apr 1, 2021
0392bda
ci: fix push main and dev
sgratzl Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,23 +61,22 @@ jobs:
echo "::set-output name=tag::$imageTag"
echo "::set-output name=repo::ghcr.io/${{ github.repository }}"
- name: Push Dev Tag
if: startsWith(github.ref, 'refs/heads/dev')
Copy link
Contributor

@krivard krivard Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we'll end up tagging twice if github.ref is 'refs/heads/main'?

Copy link
Contributor

@krivard krivard Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the image job runs anyhow just for main and dev

ah, nevermind

Copy link
Member Author

@sgratzl sgratzl Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the job runs for both main and dev and each will create its own docker tag. For dev, it is :dev for main it is :latest and :v${currentVersion}

run: |
docker tag repo ${{ steps.tagname.outputs.repo }}:${{ steps.tagname.outputs.tag }}
docker push ${{ steps.tagname.outputs.repo }}:${{ steps.tagname.outputs.tag }}
- name: Extract version
if: startsWith(github.ref, 'refs/heads/main')
id: extract_version
run: node -pe "'::set-output name=version::' + require('./package.json').version"
- name: Push Version Tag Tag
if: startsWith(github.ref, 'refs/heads/main')
run: |
docker tag repo ${{ steps.tagname.outputs.repo }}:v{{ steps.extract_version.outputs.version }}
docker push ${{ steps.tagname.outputs.repo }}:v{{ steps.extract_version.outputs.version }}
- name: Trigger Webhook
run: |
# trigger a webhook update
curl -H "Authorization: Bearer ${{ secrets.DELPHI_DEPLOY_WEBHOOK_TOKEN }}" \
-X POST ${{ secrets.DELPHI_DEPLOY_WEBHOOK_URL }} \
-H "Content-Type: application/x-www-form-urlencoded" \
-d "repository=${{ steps.tagname.outputs.repo }}&tag=${{ steps.tagname.outputs.tag }}"
- name: Push Version Tag Tag
if: startsWith(github.ref, 'refs/heads/main')
run: |
docker tag repo ${{ steps.tagname.outputs.repo }}:v${{ steps.extract_version.outputs.version }}
docker push ${{ steps.tagname.outputs.repo }}:v${{ steps.extract_version.outputs.version }}