adding carousel item for forecast dashboard #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for cmu-delphi-main ready! Built with commit bcaef05 |
Contributor
|
hero image 1x Hero image 2x Link to figma mock: https://www.figma.com/file/fDDK26m1S1rqhxFtk9edr5/v2_DELPHI_VisD-UI-Kit?node-id=402%3A2646 @kateharwood here you go :) |
Contributor
|
I focused the visible area on the chart and key below it. Since the left panel was mostly covered by the overlay I thought this might focus the user on the cool line chart comparisons that are possible. If that works for you? |
kateharwood
commented
Mar 16, 2021
Member
|
please also add a |
Member
|
and a resolution of 1440x500 is enough |
sgratzl
requested changes
Mar 17, 2021
Member
sgratzl
left a comment
sgratzl
left a comment
There was a problem hiding this comment.
see comments before regarding image types and sizes
Contributor
Author
|
@sgratzl done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.