style: fix for ios wrapped height #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for cmu-delphi-main ready! Built with commit 28a4498 |
Contributor
|
Without this device, what should I be looking for? I added an emulated device to devtools as per this article, but I don't notice a difference when I inspect both pages. |
Member
Author
|
see also https://www.figma.com/file/IiYu74VmEi4GVS4bnYaTd6/Delphi-Site-Redesign?node-id=2269%3A56270 it is less about the dimensions but somehow some Safari version interpret some rules differently. I guess for a proper reproduce, you need an iOS 13 device or something like browserstack
|
tildechris
approved these changes
Mar 9, 2021
Contributor
tildechris
left a comment
tildechris
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the clarification. I'll make sure we get continued feedback from people w/ recent iOS hardware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on iPhone11 the view looks packed to the height with overlapping content and footer. This should fix it