-
Notifications
You must be signed in to change notification settings - Fork 7
Blog post for unpacking case fatality rate #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for cmu-delphi-main ready! Built with commit 679998b |
capnrefsmmat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a quick formatting check; I haven't read the text yet, but that can happen in the next few days
…nneccessary math mode
|
I'll start trying to get this into our final formatting in the next few days. Could you provide a short one-sentence bio for each author, like the ones at the end of the new causal post? Include a website if the author has one. You can post the bios in a comment here and I'll get them incorporated. |
|
Also, a short 150-character summary to go in the post list. You might also start thinking about a short tweet thread to accompany the post. You can see some examples @CmuDelphi; they usually highlight a couple key graphs and summarize the main results. |
Sure thing, here are the bios: (Cheng Cheng)[https://linkedin.com/in/cheng-cheng-419718106] is a PhD student in Machine Learning and Public Policy at CMU and is a member of Delphi. (Jeremy Chen Weiss)[https://www.andrew.cmu.edu/user/jweiss2/] is an Assistant Professor of Health Informatics at CMU and is a member of Delphi. (Zachary Chase Lipton)[acmilab.org] is an Assistant Professor of Operations Research and Machine Learning at CMU and is a member of Delphi. |
Here's a 149-character summary: |
|
I just updated the setup of this blog post and compiled a proper version. changed
TODO
current version: https://deploy-preview-226--cmu-delphi-main.netlify.app/blog/2021/01/22/unpacking-the-drop-in-covid-19-case-fatality-rates/ |
sgratzl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup should be fine now
sgratzl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup should be fine now
we can set a background directly in the SVG files. If we would do it in the HTML popup, the white area would cover the whole screen. |
|
I'm not a fan of using colored text here; the post already uses bold, italics, and bold-italic text, and four emphasis styles is a bit too much. Also, I'd change the top-level headings to |
and remove blue highlight
done |
I added an APA bibliography style for now, some potential new tags (not sure if it falls under any of the previous tags), and an acknowledgements section. Where do you normally find hero images? |
Two best royalty free sites are unsplash.com and pexels.com. You can also message me on slack and I can help if you have a rough idea of what you're looking for. |
|
Dunno, when the topic is case fatality rate, isn't singling out one person in the image a bit morbid? |
|
Just added a hero image under the static/blog/images folder titled "unpack-cfr-full-size.jpg" and "unpack-cfr-thumb.jpg." Are there any other remaining TODOs for this blog post? |
sgratzl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok from a technical perspective
Well, the topic is literally about mortality, but yes perhaps it's too evocative. I saw the hospital room hero image, and I like that better. LGTM from me too, so we just need to finalize the content. |
|
hi all, after making a pass (see my commit) I approve the content and am happy for the post to be deployed provided that engineering confirms that everything renders properly and that my line breaking didn't screw up anything. |
zackchase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided that this passes engineering checks for rendering properly to HTML, I approve this content.
tildechris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.



I had trouble running blogdown and serving the post on my machine, but otherwise I followed the instructions on the README for where to place the blog post and dependencies.