Skip to content

Conversation

@hlzhou
Copy link
Contributor

@hlzhou hlzhou commented Jan 19, 2021

I had trouble running blogdown and serving the post on my machine, but otherwise I followed the instructions on the README for where to place the blog post and dependencies.

@netlify
Copy link

netlify bot commented Jan 19, 2021

Deploy preview for cmu-delphi-main ready!

Built with commit 679998b

https://deploy-preview-226--cmu-delphi-main.netlify.app

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a quick formatting check; I haven't read the text yet, but that can happen in the next few days

@capnrefsmmat
Copy link
Contributor

I'll start trying to get this into our final formatting in the next few days. Could you provide a short one-sentence bio for each author, like the ones at the end of the new causal post? Include a website if the author has one. You can post the bios in a comment here and I'll get them incorporated.

@capnrefsmmat
Copy link
Contributor

Also, a short 150-character summary to go in the post list.

You might also start thinking about a short tweet thread to accompany the post. You can see some examples @CmuDelphi; they usually highlight a couple key graphs and summarize the main results.

@hlzhou
Copy link
Contributor Author

hlzhou commented Jan 21, 2021

I'll start trying to get this into our final formatting in the next few days. Could you provide a short one-sentence bio for each author, like the ones at the end of the new causal post? Include a website if the author has one. You can post the bios in a comment here and I'll get them incorporated.

Sure thing, here are the bios:
(Helen Zhou)[https://www.helen-zhou.com] is a PhD student in the Machine Learning Department at CMU and is a member of Delphi.

(Cheng Cheng)[https://linkedin.com/in/cheng-cheng-419718106] is a PhD student in Machine Learning and Public Policy at CMU and is a member of Delphi.

(Jeremy Chen Weiss)[https://www.andrew.cmu.edu/user/jweiss2/] is an Assistant Professor of Health Informatics at CMU and is a member of Delphi.

(Zachary Chase Lipton)[acmilab.org] is an Assistant Professor of Operations Research and Machine Learning at CMU and is a member of Delphi.

@hlzhou
Copy link
Contributor Author

hlzhou commented Jan 21, 2021

Also, a short 150-character summary to go in the post list.

You might also start thinking about a short tweet thread to accompany the post. You can see some examples @CmuDelphi; they usually highlight a couple key graphs and summarize the main results.

Here's a 149-character summary:
Since the pandemic started, case fatality has plummeted. How can we unpack treatment improvements versus younger patients, increased testing, etc.?

@sgratzl
Copy link
Member

sgratzl commented Jan 22, 2021

I just updated the setup of this blog post and compiled a proper version.

changed

  • updated to latest dev
  • added author infos
  • added summary
  • fixed the blogdown setup - somehow the bib file couldn't be parsed

TODO

  • hero image?
  • tags?
  • should we try to style the bibliography a bit?

current version: https://deploy-preview-226--cmu-delphi-main.netlify.app/blog/2021/01/22/unpacking-the-drop-in-covid-19-case-fatality-rates/

Copy link
Member

@sgratzl sgratzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup should be fine now

@sgratzl sgratzl self-requested a review January 22, 2021 14:56
@tildechris
Copy link
Contributor

Is there a setting to give figures a white background instead of transparent? Here's what it looks like when they are enlarged:

image

Copy link
Member

@sgratzl sgratzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup should be fine now

@sgratzl
Copy link
Member

sgratzl commented Jan 22, 2021

Is there a setting to give figures a white background instead of transparent? Here's what it looks like when they are enlarged:

we can set a background directly in the SVG files. If we would do it in the HTML popup, the white area would cover the whole screen.

@sgratzl
Copy link
Member

sgratzl commented Jan 22, 2021

image

should we keep enforcing that this text is in blue?

@capnrefsmmat
Copy link
Contributor

I'm not a fan of using colored text here; the post already uses bold, italics, and bold-italic text, and four emphasis styles is a bit too much.

Also, I'd change the top-level headings to ##, since we usually use <h2>s for headers in content (since the post title is an <h1>). Subheads should go down a level as well.

@sgratzl
Copy link
Member

sgratzl commented Jan 22, 2021

I'm not a fan of using colored text here; the post already uses bold, italics, and bold-italic text, and four emphasis styles is a bit too much.

Also, I'd change the top-level headings to ##, since we usually use <h2>s for headers in content (since the post title is an <h1>). Subheads should go down a level as well.

done

@hlzhou
Copy link
Contributor Author

hlzhou commented Jan 22, 2021

I just updated the setup of this blog post and compiled a proper version.

changed

  • updated to latest dev
  • added author infos
  • added summary
  • fixed the blogdown setup - somehow the bib file couldn't be parsed

TODO

  • hero image?
  • tags?
  • should we try to style the bibliography a bit?

current version: https://deploy-preview-226--cmu-delphi-main.netlify.app/blog/2021/01/22/unpacking-the-drop-in-covid-19-case-fatality-rates/

I added an APA bibliography style for now, some potential new tags (not sure if it falls under any of the previous tags), and an acknowledgements section. Where do you normally find hero images?

@tildechris
Copy link
Contributor

Where do you normally find hero images?

Two best royalty free sites are unsplash.com and pexels.com. You can also message me on slack and I can help if you have a rough idea of what you're looking for.

@tildechris
Copy link
Contributor

What do you think about this image? I wanted to evoke a "one out X" sentiment.

one-out-of

@capnrefsmmat
Copy link
Contributor

Dunno, when the topic is case fatality rate, isn't singling out one person in the image a bit morbid?

@hlzhou
Copy link
Contributor Author

hlzhou commented Jan 26, 2021

Just added a hero image under the static/blog/images folder titled "unpack-cfr-full-size.jpg" and "unpack-cfr-thumb.jpg." Are there any other remaining TODOs for this blog post?

@sgratzl
Copy link
Member

sgratzl commented Jan 26, 2021

Copy link
Member

@sgratzl sgratzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok from a technical perspective

@sgratzl sgratzl requested a review from capnrefsmmat January 26, 2021 08:50
@tildechris
Copy link
Contributor

Dunno, when the topic is case fatality rate, isn't singling out one person in the image a bit morbid?

Well, the topic is literally about mortality, but yes perhaps it's too evocative. I saw the hospital room hero image, and I like that better. LGTM from me too, so we just need to finalize the content.

@zackchase
Copy link
Contributor

hi all, after making a pass (see my commit) I approve the content and am happy for the post to be deployed provided that engineering confirms that everything renders properly and that my line breaking didn't screw up anything.

Copy link
Contributor

@zackchase zackchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided that this passes engineering checks for rendering properly to HTML, I approve this content.

Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sgratzl sgratzl merged commit f846a87 into dev Jan 28, 2021
@sgratzl sgratzl deleted the unpack-cfr branch January 28, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants