Skip to content

Conversation

@capnrefsmmat
Copy link
Contributor

Replace problematic code in old posts with as.covidcast_signal, which should be future-proof. Also, add necessary requirements to CI.

These can be replaced with as.covidcast_signal, which is much clearer.
udunits2 is used by the packages. Upgrade to latest covidcast Python
package.
@capnrefsmmat capnrefsmmat requested a review from sgratzl January 18, 2021 22:17
@netlify
Copy link

netlify bot commented Jan 18, 2021

✔️ Deploy preview for cmu-delphi-main ready!

🔨 Explore the source changes: 00fd5b1

🔍 Inspect the deploy logs: https://app.netlify.com/sites/cmu-delphi-main/deploys/60071816ac187e00071a3fe2

😎 Browse the preview: https://deploy-preview-220--cmu-delphi-main.netlify.app

@capnrefsmmat
Copy link
Contributor Author

(we'll have to try the CI again once the covidcast package fix is released, so there's no longer a usmap dependency)

@sgratzl
Copy link
Member

sgratzl commented Jan 19, 2021

(we'll have to try the CI again once the covidcast package fix is released, so there's no longer a usmap dependency)

we can also just add the r-usmap dependency to the environment.yml file for now.

Copy link
Member

@sgratzl sgratzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgratzl sgratzl merged commit 801a067 into dev Jan 19, 2021
@sgratzl sgratzl deleted the blog/fix-old-posts branch January 19, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants