Skip to content

Conversation

@melange396
Copy link
Contributor

...

@melange396 melange396 changed the base branch from rzatserkovnyi/improve-errors to dev February 6, 2025 16:54
@melange396 melange396 marked this pull request as draft February 6, 2025 16:59
@melange396 melange396 marked this pull request as ready for review February 6, 2025 16:59
@melange396
Copy link
Contributor Author

i dont know how to trigger the creation of the netlify preview :'(
https://deploy-preview-86--cmu-delphi-epivis.netlify.app/ is 404

...mostly just a commit to try to trigger netlify preview generation
@melange396 melange396 changed the base branch from dev to rzatserkovnyi/improve-errors February 6, 2025 17:09
@melange396
Copy link
Contributor Author

pushing another commit got it to work!

@melange396 melange396 requested a review from rzats February 6, 2025 17:16
@melange396
Copy link
Contributor Author

This looks like it works, but it introduces a build error. It can be seen in the ci GitHub Action, during the "Run npm run build" step:

(!) Plugin typescript: @rollup/plugin-typescript TS2322: Type 'Promise<unknown>' is not assignable to type 'Promise<T>'.
  Type 'unknown' is not assignable to type 'T'.
    'T' could be instantiated with an arbitrary type which could be unrelated to 'unknown'.
src/api/EpiData.ts: (60:5)

60     return fetch(url.toString(), fetchOptions).then(processResponse);
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

(!) Plugin typescript: @rollup/plugin-typescript TS2322: Type 'Promise<unknown>' is not assignable to type 'Promise<T>'.
src/api/EpiData.ts: (65:3)

 65   return fetch(url.toString(), {
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 66     ...fetchOptions,
    ~~~~~~~~~~~~~~~~~~~~
... 
 68     body: params,
    ~~~~~~~~~~~~~~~~~
 69   }).then(processResponse);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~

Base automatically changed from rzatserkovnyi/improve-errors to dev February 6, 2025 20:36
@melange396 melange396 marked this pull request as draft March 5, 2025 18:38
@melange396 melange396 closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants