Add persistence to API keys #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melange396
requested changes
Oct 2, 2024
Contributor
melange396
left a comment
melange396
left a comment
There was a problem hiding this comment.
Can we change this so that all of the api key and authorization token fields across the different endpoints share the same singular backing store? That will save the user from having to enter their key into the forms of each individual endpoint, plus our permissions model allows us to grant permission to multiple endpoints via just one key (so a user should never need a plurality of keys).
Can we move the "Save API keys & auth tokens" checkbox next to or right above the "FETCH DATA" button, and can we make it default to unchecked?
melange396
requested changes
Nov 19, 2024
melange396
requested changes
Nov 21, 2024
melange396
requested changes
Dec 9, 2024
Contributor
melange396
left a comment
melange396
left a comment
There was a problem hiding this comment.
i think there is still one more superfluous variable, but otherwise this is probably good to go.
This was referenced Feb 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63.
apiKeySelections. This is populated when the application is initially launched, and saved in the browser's local storage.