Skip to content

Conversation

@rzats
Copy link
Contributor

@rzats rzats commented Sep 17, 2024

Closes #59:

  • Changes the display name of "FluView" to "ILINet (aka FluView)".
  • Changes the default-enabled signal (during initial page load) from "ili" to "wili".
  • Changes the display of the signal names from "ili" to "%ILI" and "wili" to "%wILI".

@rzats rzats requested a review from melange396 September 17, 2024 14:28
Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but lets make the new argument to loadEpidata() and loadDataSet() name more descriptive and with more obvious intent... How about columnsToRename or columnRenamings instead of columnNames?

@rzats rzats requested a review from melange396 September 24, 2024 11:56
@rzats
Copy link
Contributor Author

rzats commented Sep 24, 2024

@melange396 fixed!

Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@rzats rzats merged commit 4fcef78 into dev Sep 24, 2024
@rzats rzats deleted the rzatserkovnyi/fluview-display branch September 24, 2024 14:27
This was referenced Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FluView (aka ILINet) display/presentation upadtes

3 participants