Skip to content

Fix empty datasets locking UI #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Fix empty datasets locking UI #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1c1ff7
Fix empty datasets locking UI
rzats Sep 16, 2024
fa3f51f
warning not needed
rzats Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/api/EpiData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,9 @@ function loadEpidata(
}
points.push(new EpiPoint(date, row[col] as number));
}
datasets.push(new DataSet(points, col, params));
if (points.length > 0) {
datasets.push(new DataSet(points, col, params));
}
}
return new DataGroup(name, datasets);
}
Expand Down Expand Up @@ -135,7 +137,18 @@ export function loadDataSet(
url.searchParams.set('format', 'json');
return fetchImpl<Record<string, unknown>[]>(url)
.then((res) => {
return loadEpidata(title, res, columns, { _endpoint: endpoint, ...params });
const data = loadEpidata(title, res, columns, { _endpoint: endpoint, ...params });
if (data.datasets.length == 0) {
return UIkit.modal
.alert(
`
<div class="uk-alert uk-alert-error">
<a href="${url.href}">API Link</a> returned no data.
</div>`,
)
.then(() => null);
}
return data;
})
.catch((error) => {
console.warn('failed fetching data', error);
Expand Down