Add correlation metrics to the table #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tildechris
commented
Mar 30, 2021
sgratzl
reviewed
Mar 30, 2021
Previous impl used a map, here we walk both lists directly. Arguably this is a bit easier to read than two reduce statements.
sgratzl
approved these changes
Mar 31, 2021
Member
sgratzl
left a comment
sgratzl
left a comment
There was a problem hiding this comment.
just a small comment but besides that looks good
dlaliberte
reviewed
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds metrics to the correlation table on the indicator details page.