Skip to content

Conversation

@dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Aug 12, 2023

Fix #64
Fix #145
Fix #53
Fix #124
Fix #109
Fix #92
Fix #98

@dshemetov dshemetov requested a review from brookslogan as a code owner August 12, 2023 00:02
@dshemetov dshemetov requested a review from dsweber2 August 12, 2023 00:03
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how this fixes #64? otherwise seems good!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would maybe call removing a function a minor release rather than a bugfix, but nbd really

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair

@dshemetov
Copy link
Contributor Author

dshemetov commented Aug 12, 2023

There's a sneaky unname that fixed #64. The code that does the metadata parsing is pretty hard to understand tbh.

names(l) <- paste(x$source, names(l), sep = ":")
l
}))
all_signals <- do.call(c, unname(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the #64 fix

@dshemetov dshemetov merged commit 1436691 into dev Aug 12, 2023
@dshemetov dshemetov deleted the ds/tab-complete branch August 12, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants