Skip to content

protect against failed type casts #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2020
Merged

protect against failed type casts #97

merged 1 commit into from
Apr 30, 2020

Conversation

@dfarrow0
Copy link
Contributor

@dfarrow0 dfarrow0 commented Apr 30, 2020

  • strings where numbers are expected shouldn't cause the importer to
    crash
  • catch ValueError and report the field as invalid
  • add unit tests which would have caught this failure mode
  • unit and integration tests pass

@dfarrow0
protect against failed type casts
2cfdc5f 
- strings where numbers are expected shouldn't cause the importer to 
crash
- catch ValueError and report the field as invalid
- add unit tests which would have caught this failure mode
- unit and integration tests pass
@undefx undefx merged commit d188484 into cmu-delphi:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dfarrow0 @undefx