DBLoadStateException: halt acquisition when unexpected data found in load table #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses issue #941
krivard
approved these changes
Aug 31, 2022
Contributor
krivard
left a comment
krivard
left a comment
There was a problem hiding this comment.
Assuming the SQL in test_db is begrudging, 🚀
Comment on lines
+39
to
+43
| self._db._cursor.execute(f''' | ||
| INSERT INTO {self._db.load_table} | ||
| (source, `signal`, geo_type, geo_value, time_type, time_value, issue, `lag`, value_updated_timestamp) | ||
| VALUES | ||
| ('sr', 'si', 'gt', 'gv', 'tt', 3, 8, 5, 13)''') |
Contributor
There was a problem hiding this comment.
hmmm i kinda wanna find a way to refactor this out just so we don't have to continually mess with it when we make more changes. did you already look at that?
Collaborator
Author
There was a problem hiding this comment.
twas indeed quite begrudging. ive thought about a better way to handle it, but i cant really come up with something that bothers me less. i also had to do something similar with the AI counter fix method here
| """Test that the row count is returned""" | ||
| mock_connector = MagicMock() | ||
| database = Database() | ||
| database.count_all_load_rows = lambda:0 # simulate an empty load table |
xavier-xia-99
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #941
a question remains about how to handle the new exception in
csv_to_database.py:upload_archive-- i would argue the behavior i have here is correct: it stops processing any more files and leaves them where they are. the exception condition would arise because of a problem with the database (and not with the files) so it should not handle unprocessed files witharchive_as_failed. if this breaks some filesystem maintenance paradigm though, im fine with changing it.