Skip to content

Repair runtime problems with mergeddim acquisition #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2022
Merged

Repair runtime problems with mergeddim acquisition #940

merged 2 commits into from
Jun 28, 2022

Conversation

@krivard
Copy link
Contributor

@krivard krivard commented Jun 28, 2022

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

  • Switch to two quick joins when setting is_latest instead of one slow join
  • add merged_key_id indexes
  • fix bad syntax when logging exceptions
  • automatically call dbjobs after insert_batch

@krivard
Repair runtime problems with mergeddim acquisition.
0e89cab 
* Switch to two quick joins when setting is_latest instead of one slow join
* add merged_key_id indexes
* fix bad syntax when logging exceptions
* automatically call dbjobs after insert_batch
@krivard krivard requested a review from melange396 June 28, 2022 14:51
melange396
melange396 approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@krivard
Better repair.
57a7a94 
Knocks out an additional unnecessary step in the query plan; we don't need the view to join merged_dim for us because we already did that
@melange396
Copy link
Collaborator

melange396 commented Jun 28, 2022

even better!

@krivard krivard merged commit fbf878e into krivard/v4-rpp-mergeddim-leftjoin Jun 28, 2022
@krivard krivard deleted the krivard/v4-rpp-mergeddim-leftjoin-repair branch June 28, 2022 15:10
@krivard krivard mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melange396 melange396 melange396 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krivard @melange396