Remove remaining wip pieces in tests #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
v4-schema-revisions-release-prep-prep
to
v4-schema-revisions-release-prep
June 15, 2022 20:14
melange396
reviewed
Aug 30, 2022
Collaborator
melange396
left a comment
melange396
left a comment
There was a problem hiding this comment.
this looks great, but im confused by the one line change that i pointed out...
| csv_importer_impl=mock_csv_importer) | ||
|
|
||
| self.assertEqual(modified_row_count, 4) | ||
| self.assertEqual(modified_row_count, 1) |
Collaborator
There was a problem hiding this comment.
i know this isnt exactly recent in your memory anymore, but why did this change to 1 instead of to 3??
Contributor
Author
There was a problem hiding this comment.
good question, let me look around. since tests pass, there must've been some change to this test in v4.
Contributor
Author
There was a problem hiding this comment.
thanks for pointing this out! i made a fix, so it's 3 now. here's an explanation:
- we have a database mock object, which overwrites
insert_or_update_bulk - we didn't even count how many rows this function was passed, we just updated the mock
return_valueargument - so i rewrote this so
insert_or_update_bulk = MagicMock(wraps=iter_len)whereiter_lenis just a function that counts the number of items in the iterable passed toinsert_or_update_bulk. so now we correctly getmodified_row_count == 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tests in #903 still had WIP references. Removed those.