Skip to content

Conversation

@krivard
Copy link
Contributor

@krivard krivard commented Oct 24, 2021

Installation script ensures nothing but code winds up in the resulting Docker images.

Refresh script automatically keeps track of what's running, shutdown/build/run procedures, and test bindmounts. We've got people copy-pasting whole paragraphs of shell commands and losing track of which copypastes do what, and that's just not necessary.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@krivard krivard requested a review from TaraLakdawala October 24, 2021 14:54
Copy link
Contributor Author

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes from Xavier

@krivard krivard requested review from xavier-xia-99 and removed request for TaraLakdawala March 8, 2022 17:57
@krivard krivard force-pushed the krivard/gentle-development branch from 35a0f3c to 58418aa Compare March 8, 2022 18:19
@krivard
Copy link
Contributor Author

krivard commented Mar 8, 2022

(rebased onto dev to incorporate patches added there since October)

Copy link

@xavier-xia-99 xavier-xia-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited syntax error and added mount argument as per code review

xavier-xia-99
xavier-xia-99 previously approved these changes Jun 18, 2022
Copy link

@xavier-xia-99 xavier-xia-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scripts are working and speed up work processes.

@krivard
Copy link
Contributor Author

krivard commented Jun 21, 2022

@xavier-xia-99 thanks -- I'll rebase this to dev HEAD and merge.

@krivard krivard force-pushed the krivard/gentle-development branch from 58418aa to bef7833 Compare June 21, 2022 14:03
@krivard krivard merged commit a3cf65b into dev Jun 21, 2022
@krivard krivard deleted the krivard/gentle-development branch June 21, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants