Add structured logger to epidata, and log metadata generation #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melange396
reviewed
Feb 5, 2021
melange396
reviewed
Feb 5, 2021
Contributor
|
Waiting to merge until we have the bandwidth to install structlog on prod |
Contributor
Author
|
Structlog is in but lets wait to merge until we have the regular system functional again (don't want to introduce additional risk) |
Contributor
|
Primary is relatively healthy; merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #403
Note that this needs structlog installed before running since this adds a new dependency.
The logger is a fork of the logger in delphi_utils. We can unify these if we extract delphi utils into a standalone package.