-
Notifications
You must be signed in to change notification settings - Fork 67
Flask based API #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Flask based API #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
possible error fixes
[flask]: remove analytics tracking
Co-authored-by: Samuel Gratzl <[email protected]>
Add Flask server files to correct deployment location
Hack to move flask tests out of the way before py3test
Hide the remaining flask tests from py3test
build: try to fix moving tests
build: match is required for globbing
[flask] separate image step and only build on certain branches
krivard
approved these changes
May 5, 2021
Contributor
krivard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up on #350 with the branch in this repo for CI purposes.
based on #337
closes #178 and closes #177
proof of concept that we could also use Python for the API and thus get rid of PHP for hosting the API. The public interface remains the same but allows way more flexibility if we want to. Moreover, it is python thus we can unit test/lint/format it properly.
There is also a Dockerfile that will create a docker image to run it.
for the 414 failing unit test, see also benoitc/gunicorn#2487