-
Notifications
You must be signed in to change notification settings - Fork 67
Ttownes/dsew cpr edits #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ttownes/dsew cpr edits #1404
Conversation
Corrected signal dates, added signal and link to Delphi blog.
Small line break added
nmdefries
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove changes to Gem dependencies. We can do that together on Thursday since it requires some fancy git.
docs/Gemfile
Outdated
|
|
||
| # This is the default theme for new Jekyll sites. You may change this to anything you like. | ||
| gem "minima", "~> 2.0" | ||
| gem "jekyll-include-cache" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: we probably shouldn't include changes to the Ruby set-up files (Gemfile and Gemfile.lock) since I'm not sure how those will affect the production/public version of the site. (It is possible that these dependencies are actually out of date, but that should be handled and tested separately.)
| See our [blog post](https://delphi.cmu.edu/blog/2020/11/05/a-syndromic-covid-19-indicator-based-on-insurance-claims-of-outpatient-visits/#backfill) for more information on backfill. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I don't think DSEW is based on insurance claims so I think the blog post blurb isn't too relevant here (should be linked on CHNG and doctors-visits, though).
| See our [blog post](https://delphi.cmu.edu/blog/2020/11/05/a-syndromic-covid-19-indicator-based-on-insurance-claims-of-outpatient-visits/#backfill) for more information on backfill. | |
| See our [blog post](https://delphi.cmu.edu/blog/2020/11/05/a-syndromic-covid-19-indicator-based-on-insurance-claims-of-outpatient-visits/#backfill) for more information on backfill. | |
Explaining what NAAT means Co-authored-by: nmdefries <[email protected]>
blog post deletion
…i/delphi-epidata into ttownes/dsew-cpr-edits
This reverts commit 0eb42fc.
|




Summary:
Fix a few Gem issues for Windows, edit signal dates, add blog post link, and add one signal to dsew-cpr source
Prerequisites:
devbranchdev