Skip to content

Conversation

@tinatownes
Copy link
Collaborator

Summary:

Fix a few Gem issues for Windows, edit signal dates, add blog post link, and add one signal to dsew-cpr source

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@tinatownes tinatownes requested a review from nmdefries March 12, 2024 01:23
Small line break added
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove changes to Gem dependencies. We can do that together on Thursday since it requires some fancy git.

docs/Gemfile Outdated

# This is the default theme for new Jekyll sites. You may change this to anything you like.
gem "minima", "~> 2.0"
gem "jekyll-include-cache"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: we probably shouldn't include changes to the Ruby set-up files (Gemfile and Gemfile.lock) since I'm not sure how those will affect the production/public version of the site. (It is possible that these dependencies are actually out of date, but that should be handled and tested separately.)

Comment on lines 83 to 84
See our [blog post](https://delphi.cmu.edu/blog/2020/11/05/a-syndromic-covid-19-indicator-based-on-insurance-claims-of-outpatient-visits/#backfill) for more information on backfill.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I don't think DSEW is based on insurance claims so I think the blog post blurb isn't too relevant here (should be linked on CHNG and doctors-visits, though).

Suggested change
See our [blog post](https://delphi.cmu.edu/blog/2020/11/05/a-syndromic-covid-19-indicator-based-on-insurance-claims-of-outpatient-visits/#backfill) for more information on backfill.
See our [blog post](https://delphi.cmu.edu/blog/2020/11/05/a-syndromic-covid-19-indicator-based-on-insurance-claims-of-outpatient-visits/#backfill) for more information on backfill.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nmdefries nmdefries self-requested a review March 14, 2024 17:29
@nmdefries nmdefries merged commit a7da942 into dev Mar 14, 2024
@nmdefries nmdefries deleted the ttownes/dsew-cpr-edits branch March 14, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants