Skip to content

Conversation

@minhkhul
Copy link
Contributor

@minhkhul minhkhul commented Aug 8, 2023

Closes #943

Screenshot 2023-08-10 at 4 15 00 PM Screenshot 2023-08-10 at 4 15 25 PM

@minhkhul minhkhul requested review from melange396 and rzats August 9, 2023 14:18
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not bad! in the "Example URLs" section, could you also show the equivalent of both examples that use these alternative parameters too?

@minhkhul minhkhul requested a review from melange396 August 10, 2023 20:14
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple grammar things

minhkhul and others added 2 commits August 14, 2023 12:34
@minhkhul minhkhul requested a review from melange396 August 14, 2023 16:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melange396 melange396 merged commit c199403 into dev Aug 14, 2023
@melange396 melange396 deleted the document_syntax_feature branch August 14, 2023 16:58
melange396 added a commit that referenced this pull request Aug 17, 2023
* Performance testing testing workflow (#1253)

* New CTIS publication (#1255)

* Newer CTIS publication

* bring loggers in sync and add multiproc capabilities (#1254)

* add syntax feature documentation (#1256)

* Newest CTIS publication

* chore: sync to www-covidcast release v3.2.7

* moving quidel signals to non-public access (#1261)

with integration tests!

---------

Co-authored-by: Dmytro Trotsko <[email protected]>

* chore: release delphi-epidata 4.1.8

---------

Co-authored-by: Dmytro Trotsko <[email protected]>
Co-authored-by: Rostyslav Zatserkovnyi <[email protected]>
Co-authored-by: Alex Reinhart <[email protected]>
Co-authored-by: nmdefries <[email protected]>
Co-authored-by: melange396 <[email protected]>
Co-authored-by: minhkhul <[email protected]>
Co-authored-by: minhkhul <[email protected]>
Co-authored-by: melange396 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document new syntax features for covidcast endpoint

3 participants