Skip to content

[JIT]: remove stream_results from db options for speed tests #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

[JIT]: remove stream_results from db options for speed tests #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
864f56d
Server: remove stream_results from db options
dshemetov Dec 8, 2022
b9f71db
CI: update tag to build image
dshemetov Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
image:
needs: build
# only on main and dev branch
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/dev'
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/dev' || github.ref == 'refs/heads/ds/dev-no-streaming'

runs-on: ubuntu-latest
steps:
Expand All @@ -131,6 +131,9 @@ jobs:
if [ "$imageTag" = "main" ] ; then
imageTag="latest"
fi
if [ "$imageTag" = "ds/dev-no-streaming" ] ; then
imageTag="dev-no-streaming"
fi
echo "::set-output name=tag::$imageTag"
echo "::set-output name=repo::ghcr.io/${{ github.repository }}"
- name: Push Dev Tag
Expand Down
2 changes: 1 addition & 1 deletion src/server/_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def run_query(p: APrinter, query_tuple: Tuple[str, Dict[str, Any]]):
query, params = query_tuple
# limit rows + 1 for detecting whether we would have more
full_query = text(limit_query(query, p.remaining_rows + 1))
return db.execution_options(stream_results=True).execute(full_query, **params)
return db.execute(full_query, **params)


def _identity_transform(row: Dict[str, Any], _: Row) -> Dict[str, Any]:
Expand Down