Rebuild documentation for covidcast 0.5.2 #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have testthat in Suggests, not Imports, because it's only used in tests. But using this in .request_meta() makes it a runtime dependency. Instead of making users install it, we copy the function over, as suggested in the testthat documentation.
dsweber2
approved these changes
Aug 22, 2023
dsweber2
left a comment
dsweber2
left a comment
There was a problem hiding this comment.
Depending on how frequently we're releasing, might make sense to add something like a sync-dev bot which automatically makes a pull request for changes from any release branch to main. https://github.com/cmu-delphi/delphi-epidata/blob/8918506dd4c5f362243819313f8cf29eed7636ed/.github/workflows/release-helper.yml#L129C12-L129C12
|
Wait this is actually not building. Looks like |
This ensures CRAN does not have to make API calls and potentially hit our API limits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized I never merged this, so the docs site still shows the old version. This is already released on CRAN.