Handle cases where value and quantile columns can't be read as numeric
#654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
approved these changes
Jul 28, 2023
Collaborator
dshemetov
left a comment
dshemetov
left a comment
There was a problem hiding this comment.
Looks good. Given how varied the data seems to be, actually pretty nice that we can handle it all with fread and a little bit of manual conversion.
Contributor
Author
|
@dshemetov could you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format differences in forecaster input files means that
valueandquantilefields can't all be read as numeric. To avoid errors, read as character and cast to double later. Also specify severalNA-equivalent values to getget_forecaster_predictionsworking in more cases and to avoid warnings when casting to double inget_forecaster_predictions_alt.The
NAaddition fixesget_forecaster_predictionsfor 8 of the 10 forecasters where read fails for some dates. To fix the remaining failures (forPSI-DRAFTandPSI-DICEfor some dates), apply the same character->double conversion as above.