R pkg devel ta #503
Merged
R pkg devel ta #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 19, 2021 13:32
This is just a starting point; we can add additional bibEntry values as other sources become available (the glmnet package has a good example of this)
taylor-arnold
requested review from
capnrefsmmat,
krivard and
sgsmob
as code owners
sgsmob
approved these changes
Mar 19, 2021
Contributor
sgsmob
left a comment
sgsmob
left a comment
There was a problem hiding this comment.
In the future would prefer to separate these out into 2-3 separate PRs but what we have here is all ok.
Author
|
I understand the desire to localize changes; that is why I put each resolution into a different commit. However, I don't think there is a way to do a pull request on a specific commit; it is only possible to specify a branch to merge with as far as I am aware. So, I would mean that—unless I stop working each time I resolve an issue while it is reviewed—I need to create brand new branches for every single issue. Is that really necessary? |
This was referenced Mar 19, 2021
taylor-arnold
pushed a commit
that referenced
this pull request
Mar 19, 2021
Fixing the wrong URL, re: PR #503
taylor-arnold
pushed a commit
that referenced
this pull request
Mar 19, 2021
Fixing the wrong URL, re: PR #503
sgratzl
added a commit
to cmu-delphi/www-main
that referenced
this pull request
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes several commits which do the follow:
fips_to_nameby splitting into two function, as discussed in Make fips_to_abbr behave in a more predictable way #421