Update SirCAL logging #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgsmob
reviewed
Feb 9, 2021
Contributor
sgsmob
left a comment
sgsmob
left a comment
There was a problem hiding this comment.
Just a few questions about what is going on here but otherwise looks good
|
|
||
| if len(complaints) > 0: | ||
| for complaint in complaints: | ||
| LOGGER.critical(event="signal out of SLA", |
Contributor
There was a problem hiding this comment.
Why does this need to be moved?
Contributor
Author
There was a problem hiding this comment.
Old: each line-level complaint was being logged one at a time (one line per type/source/signal/geo combo)
New: only the aggregated complaint is logged (one line per type/source; signal/geo aggregated)
(this makes it much more useful for alerting)
| data_source=complaint.data_source, | ||
| signal=complaint.signal, | ||
| geo_types=complaint.geo_types, | ||
| last_updated=complaint.last_updated.strftime("%Y-%m-%d")) |
Contributor
There was a problem hiding this comment.
This argument is dropped below. Was that intentional?
Contributor
Author
There was a problem hiding this comment.
Yeah, in the new code it's been pulled directly into the aggregated message.
sgsmob
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update SirCAL logging to support replicating alerts through elastic
Changelog
Fixes