Add support for writing logs to file via param. #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinandrew
reviewed
Dec 15, 2020
| logger = get_structured_logger(__name__) | ||
| def get_logger(): | ||
| params = read_params() | ||
| return get_structured_logger(__name__, filename = params.get("log_filename")) |
Contributor
There was a problem hiding this comment.
is there a convention to init the logger outside the main function as a constant (as opposed to putting it right after the read_params line in run_module)? I'm not super familiar with the best practice. Otherwise this PR looks good
Contributor
Author
There was a problem hiding this comment.
I looked through a bunch of discussions on stack overflow, and there were advocates for both versions of this (and other versions too) so my reaction was that there is not a clear preference. I chose this one because it's slightly less work to pass around the logger to the individual functions (and I am also biased toward a java-ey approach).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for writing logs to file via param.
Changelog
Fixes