Skip to content

Conversation

@sgsmob
Copy link
Contributor

@sgsmob sgsmob commented Nov 2, 2020

Fixes #419. Some legacy functions and calls were not removed from the USAFacts indicator.

@sgsmob sgsmob requested a review from chinandrew November 2, 2020 18:24
@chinandrew
Copy link
Contributor

I'm getting some test failures on test_pull.py, all of the form TypeError: Can only merge Series or DataFrame objects

@sgsmob
Copy link
Contributor Author

sgsmob commented Nov 2, 2020

I'm getting some test failures on test_pull.py, all of the form TypeError: Can only merge Series or DataFrame objects

I can't replicate this; did you just do git fetch sgsmob usafacts?

@chinandrew
Copy link
Contributor

I'm getting some test failures on test_pull.py, all of the form TypeError: Can only merge Series or DataFrame objects

I can't replicate this; did you just do git fetch sgsmob usafacts?

Ok it was on my end, may have been on an old branch or something. lgtm

@krivard krivard merged commit dd5e3f2 into cmu-delphi:main Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

USAFacts is failing checks in main

3 participants