Skip to content

Fix safegraph 7d averaged signals #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 28 commits into from
Closed

Fix safegraph 7d averaged signals #345

wants to merge 28 commits into from

Conversation

@sgsmob
Copy link
Contributor

@sgsmob sgsmob commented Oct 21, 2020

Fixes #337.

Change summary

  • map the process() function using functools.partial rather than a local function.
  • Revert the output date format to be YYYYMMDD rather than YYYY-MM-DD.

eujing and others added 25 commits August 12, 2020 16:39
@eujing
Added archiving diffing utility
911c0e0
@eujing
Updated unit tests
5d3b8ec
@eujing
Updated ansible template
2d3fb80
@krivard
Merge pull request cmu-delphi#235 from cmu-delphi/main
f1cace3 
Merge main into deploy-usafacts
@krivard
Merge pull request cmu-delphi#234 from cmu-delphi/diff-uploads-usafacts
d8c7019 
Diff uploads usafacts
@sgsmob
fix broken usafacts tests to read from the proper directories
4debc31
@chinandrew
replace deprecated functions
06e4b12
@chinandrew
Remove uppercase
f6e7b78
@chinandrew
Remove print
a164e25
@chinandrew
Remove zips static file
021cbb4
@chinandrew
Fix argument
707535e
@capnrefsmmat
Add a gap detector to Sir Complainsalot
8091221 
Detects gaps in reported data, e.g. if just one day is missing but more
recent days are available.
@capnrefsmmat
Formatting fix
849263c
@capnrefsmmat
Add hospital admissions, USAFacts to Sir Complainsalot
39df546
@sgsmob
make new receiving directory in test directory
51c0c03
@krivard
Merge pull request cmu-delphi#327 from cmu-delphi/sir-gapdetector
0783ebd 
Add a gap detector to Sir Complains-a-lot
@krivard
Merge pull request cmu-delphi#331 from cmu-delphi/deploy-safegraph
bb8e17e 
Propagate safegraph 7-day average signals into main
@krivard
Issue template for feature release
0115538
@krivard
Change auto-assign of release tasks
44be069
@korlaxxalrok
Temporarily skip linting in Jenkins
a1a1b50
@krivard
Merge pull request cmu-delphi#314 from sgsmob/fix_usa_tests
b0bb289 
fix broken usafacts tests to read from the proper directories
@krivard
Merge pull request cmu-delphi#334 from cmu-delphi/deploy-usafacts
317a4d5 
Propagate USAFacts paths fix to main
@krivard
Merge pull request cmu-delphi#322 from cmu-delphi/geo_refactor_claims…
b21252f 
…hosp

Refactor claims_hosp to use new geomapper functions
@sgsmob
migrate safegraph.run back onto using functools.partial
6b96a1a
@sgsmob
fix output file format from YYYY-MM-DD to YYYYMMDD
933c6b4
krivard
krivard previously approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; I'll let today's Safegraph pipeline finish running and then merge.

@krivard krivard changed the base branch from main to deploy-safegraph October 21, 2020 18:04
@krivard krivard dismissed their stale review October 21, 2020 18:04

The base branch was changed.

krivard
krivard previously approved these changes Oct 21, 2020
View reviewed changes
@krivard
Copy link
Contributor

krivard commented Oct 22, 2020

publicly declaring my intent to resolve conflicts

@krivard krivard mentioned this pull request Oct 22, 2020
Merged
@krivard
Copy link
Contributor

krivard commented Oct 23, 2020

Superseded by #356

@krivard krivard closed this Oct 23, 2020
This was referenced Oct 27, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@krivard krivard krivard left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repair Safegraph changeset from #309

6 participants

@sgsmob @krivard @eujing @chinandrew @capnrefsmmat @korlaxxalrok