Skip to content

Remove cruise ships FIPS codes, 88888 and 99999, from JHU #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 71 commits into from
Oct 29, 2020
Merged

Remove cruise ships FIPS codes, 88888 and 99999, from JHU #335

merged 71 commits into from
Oct 29, 2020

Conversation

@dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Oct 20, 2020

Met with @sgsmob, gave a tour of the geocoding crosswalk tables processing script, and implemented small fix. Fixes #318.

eujing and others added 30 commits August 12, 2020 16:39
@eujing
Added archiving diffing utility
911c0e0
@eujing
Updated unit tests
5d3b8ec
@eujing
Updated ansible template
2d3fb80
@krivard
Merge pull request #235 from cmu-delphi/main
f1cace3 
Merge main into deploy-usafacts
add code
a24dc4d
fixed an error in unit tests
e833515
removed unused files
5f7ffa1
changed format of intermediate output dataframes
870fd20
@jingjtang
uncommented code for pulling raw data
b9a788f
Added code for using geomap utils
ad1d4d5
@krivard
Merge pull request #234 from cmu-delphi/diff-uploads-usafacts
d8c7019 
Diff uploads usafacts
@krivard
[sir-complainsalot] Add grace period and dry run
9b48cce
@eujing
Reduce df memory usage, and vectorize more
bcda25f
@sgsmob
Merge branch 'main' of github.com:cmu-delphi/covidcast-indicators int…
4a58a16 
…o weekday
@sgsmob
Merge branch 'main' of github.com:cmu-delphi/covidcast-indicators int…
c687428 
…o weekday
@krivard
Merge pull request #305 from cmu-delphi/deploy-jhu
d357d01 
Propagate fips -> county filename fix from JHU back into main
update code for geomapping using utils
81be4f4
@huisaddison
fix typo in documentation
eec5f50
@huisaddison
fix typo in documentation
0c502f7
@huisaddison
fix typo in documentation
37edbf5
@huisaddison
fix typo in documentation
3a0f9a9
@huisaddison
fix typo in documentation
a2d5768
@sgsmob
Merge branch 'main' of github.com:cmu-delphi/covidcast-indicators int…
ed4c306 
…o weekday
@sgsmob
refactor safegraph.process to pave the way for multifile processing
6a616c4
@sgsmob
tests for finding the file names in the past week
45307ad
@sgsmob
testing process_window
efdf3fd
@sgsmob
comments and formatting for pylint compliance
7ed90e1
@sgsmob @krivard
docstring updates
d0151e8 
Co-authored-by: krivard <[email protected]>
@sgsmob
lint compliance in test cases
8918ada
@sgsmob
move location of VALID_GEO_RESOLUTIONS
6b24185
capnrefsmmat and others added 18 commits October 17, 2020 14:46
@capnrefsmmat
Add hospital admissions, USAFacts to Sir Complainsalot
39df546
@sgsmob
make new receiving directory in test directory
51c0c03
@krivard
Merge pull request #225 from cmu-delphi/safegraph_patterns
261503a 
pipeline for Safegraph patterns
@sgsmob
Merge branch 'main' of github.com:cmu-delphi/covidcast-indicators int…
7c8e702 
…o weekday
@sgsmob
don't overwrite files
90a22c4
@sgsmob
remove unused import
5117b9d
@sgsmob
substring testing with 'in'
509f4d7
@sgsmob
update tests to process to include wip and 7d_avg signals
9d6394a
@sgsmob
added wip signals to params file
470e95d
@krivard
Merge pull request #327 from cmu-delphi/sir-gapdetector
0783ebd 
Add a gap detector to Sir Complains-a-lot
@krivard
Merge pull request #309 from sgsmob/weekday
ee49484 
Add 7-day average of each signal to Safegraph indicator
@krivard
Merge pull request #331 from cmu-delphi/deploy-safegraph
bb8e17e 
Propagate safegraph 7-day average signals into main
@krivard
Issue template for feature release
0115538
@krivard
Change auto-assign of release tasks
44be069
@korlaxxalrok
Temporarily skip linting in Jenkins
a1a1b50
@krivard
Merge pull request #314 from sgsmob/fix_usa_tests
b0bb289 
fix broken usafacts tests to read from the proper directories
@krivard
Merge pull request #334 from cmu-delphi/deploy-usafacts
317a4d5 
Propagate USAFacts paths fix to main
@dshemetov
Remove cruise ships FIPS codes, 88888 and 99999
84049be
@dshemetov dshemetov requested review from krivard and sgsmob October 20, 2020 18:13
@dshemetov dshemetov self-assigned this Oct 20, 2020
krivard
krivard previously approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krivard krivard changed the base branch from main to deploy-jhu October 21, 2020 18:22
@krivard krivard dismissed their stale review October 21, 2020 18:22

The base branch was changed.

sgsmob
sgsmob approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@sgsmob sgsmob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krivard
Copy link
Contributor

krivard commented Oct 21, 2020

Hold off until after the JHU fixes go live this weekend.

@krivard krivard added the blocked This task is waiting for completion of another task label Oct 21, 2020
@krivard krivard merged commit 7d50e4e into deploy-jhu Oct 29, 2020
@krivard krivard deleted the jhu_cruise_ships_fix branch October 29, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@krivard krivard krivard approved these changes

@sgsmob sgsmob sgsmob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dshemetov dshemetov

Labels

blocked This task is waiting for completion of another task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GeoMapper produces invalid counties >80000 for JHU

9 participants

@dshemetov @krivard @sgsmob @eujing @jingjtang @huisaddison @capnrefsmmat @korlaxxalrok