ght: standardizing signal names #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krivard
reviewed
Aug 12, 2020
Contributor
krivard
left a comment
krivard
left a comment
There was a problem hiding this comment.
Not ready to merge yet -- couple typos, and I'm holding off on running tests until we figure out what to do with the array->set changes.
| ] | ||
|
|
||
| assert len(res["lines"][0]["points"]) == 2 | ||
| assert [x for x in res["lines"][0]["points"][0].keys()] == ["date", "value"] |
Contributor
There was a problem hiding this comment.
These changes were added to deploy-google-health in #189, so if we want to avoid a conflict we shouldn't duplicate them here. @korlaxxalrok is that work ready to merge to main or should we hold off on this until we figure out the remaining automation details?
Contributor
There was a problem hiding this comment.
@krivard I think deploy-google_health is ready to be merged 👍
Co-authored-by: krivard <[email protected]>
Co-authored-by: krivard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.