prevent sircal from alerting on NSSP secondary signals #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhkhul
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New signals were added to NSSP in issue #2073 / PR #2074 in the hope of getting more frequent updates, but that new source data has not been appended to or revised since Oct 18, 2024 (currently ~100 days out of date).
This PR should cause Sir Complains-a-Lot to ignore those stale signals, thus preventing alerting on their age, and in turn allow us to get better alerting on the age of the "main" NSSP signals.
Some more discussion is available in a slack thread: https://delphi-org.slack.com/archives/C01LZ3A2UMU/p1736451710690869?thread_ts=1736404465.936839&cid=C01LZ3A2UMU