2034 add retry loop to Google symptoms data pull #2057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmdefries
changed the title
minhkhul
approved these changes
Oct 31, 2024
Contributor
minhkhul
left a comment
minhkhul
left a comment
There was a problem hiding this comment.
To sum up, instead or raising an error immediately like current, this PR tries one more pull if encounter backend error or internal server error. If the second pull doesn't work, error out as usual.
nmdefries
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added retry loop to handle google api request more gracefully.
Also handles a case where a server error gets miscategorized as bad request error
Associated Issue(s)