Skip to content

Conversation

@krivard
Copy link
Contributor

@krivard krivard commented Aug 7, 2020

PR for tests_per_device

@krivard krivard marked this pull request as draft August 7, 2020 18:28
@krivard krivard changed the title Quidel covidtest Quidel covidtest tests_per_device Aug 17, 2020
@krivard
Copy link
Contributor Author

krivard commented Aug 17, 2020

Try a correlation within a region across time, as recommended by Roni in the Quidel channel.

@jingjtang
Copy link
Contributor

jingjtang commented Aug 18, 2020

Needs to be solved

************* Module delphi_quidel_covidtest.run
delphi_quidel_covidtest/run.py:26:0: R0912: Too many branches (16/12) (too-many-branches)
delphi_quidel_covidtest/run.py:26:0: R0915: Too many statements (58/50) (too-many-statements)

Resolved --20200822

@jingjtang
Copy link
Contributor

jingjtang commented Aug 19, 2020

Rank Correlation across time at state and msa level:

Revised(2020-08-21):

  • Compare Quidel covid_ag_smoothed_test_per_device with jhu-csse confirmed_7dav_incidence_prop
  • negative correlations still exist
  • add number of MSA with correlations larger than 0
    QuidelCovidCorrelationAnalysis.pdf

@krivard
Copy link
Contributor Author

krivard commented Aug 20, 2020

The negative correlations are particularly suspicious for including TX. Meet with Jeremy and Roni to figure out whether we should publish this signal.

@jingjtang jingjtang marked this pull request as ready for review August 23, 2020 00:26
@krivard
Copy link
Contributor Author

krivard commented Aug 25, 2020

  • Figure out whether to comment out tests per device or disable/exclude it using configuration
  • Fix git history to drop the cache files and resolve conflicts with main

@krivard krivard requested a review from vishakha1812 August 28, 2020 18:04
@jingjtang
Copy link
Contributor

GeoMapping related work after talking to Dmitry:

  • refactor the geo_map.py to make the steps for msa/hrr_to_parent_state independent from traditional geo mapping
  • jingjing will talk with Roni next Friday about whether to stick with geographical pooling (considering parent states).

@krivard
Copy link
Contributor Author

krivard commented Aug 28, 2020

@jingjtang Do those tasks need to be completed before this can be merged? If so we should convert to draft.

@jingjtang
Copy link
Contributor

@jingjtang Do those tasks need to be completed before this can be merged? If so we should convert to draft.

Nope. We could solve them in another PR.

@krivard krivard mentioned this pull request Aug 28, 2020
2 tasks
@krivard
Copy link
Contributor Author

krivard commented Aug 28, 2020

Okay, tracking those next steps in #253 then.

For this PR, it remains to:

  • rebase to drop ght commits
  • pass review

@krivard
Copy link
Contributor Author

krivard commented Aug 28, 2020

Linter passes, tests pass on a fresh checkout. Technically I authored this so I can't review it, but Jingjing did all the work to bring it up to snuff so... :pulls lever:

@krivard krivard merged commit 43df798 into main Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants