Replace deprecated pkg_resources #1921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
approved these changes
Jun 7, 2024
Contributor
dshemetov
left a comment
dshemetov
left a comment
There was a problem hiding this comment.
Overall looks good, merged in main, and added a tiny tweak by referencing the migration guide.
Open
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1902.
Summary:
Removes uses of setuptools' deprecated
pkg_resourceslibrary - these are replaced by theimportlib_resourcesbackport. This is due to the features needed in the codebase, like accessing resources within subdirectories, only becoming available in Python 3.9+.Prerequisites:
devbranchdev