include state FIPS codes in set of all FIPS geo values #1835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that `delphi_utils.geomap.GeoMapper().get_geo_values('fips')` also includes (for example) "42000" representing all of Pennsylvania, in addition to FIPS codes in the 42001-42999 interval that represent individual counties.
see discussion at cmu-delphi/delphi-epidata#1134
dshemetov
approved these changes
Apr 18, 2023
Contributor
dshemetov
left a comment
dshemetov
left a comment
There was a problem hiding this comment.
Looks good, tests passing 👍
Also searched the repo for usage of get_geo_values and found now-redundant code adding megacounties in the validator, so removed those.
krivard
approved these changes
Apr 18, 2023
| assert geomapper.get_geo_values("nation") == {"us"} | ||
| assert geomapper.get_geo_values("hhs") == set(str(i) for i in range(1, 11)) | ||
| assert len(geomapper.get_geo_values("fips")) == 3236 | ||
| assert len(geomapper.get_geo_values("fips")) == 3293 |
Contributor
There was a problem hiding this comment.
👍 57: 50 states + 1 District (DC) + 6 Territories (Puerto Rico etc)
melange396
commented
Apr 18, 2023
| valid_geos = gmpr.get_geo_values(geomap_type) | ||
| valid_geos |= set(self.params.additional_valid_geo_values.get(geo_type, [])) | ||
| if geo_type == "county": | ||
| valid_geos |= set(x + "000" for x in gmpr.get_geo_values("state_code")) |
Contributor
Author
There was a problem hiding this comment.
lolololol, we shoulda just been using _get_valid_geo_values() instead of the geo_type_translator
Contributor
There was a problem hiding this comment.
haha actually, not a bad refactor opportunity!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that
delphi_utils.geomap.GeoMapper().get_geo_values('fips')also includes (for example) "42000" representing all of Pennsylvania, in addition to FIPS codes in the 42001-42999 interval that represent individual counties.see background discussion at cmu-delphi/delphi-epidata#1134