Skip to content

Conversation

@nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Mar 21, 2023

Description

Don't run backfill corrections file generation and don't require backfill-related params (dir, etc) if user asks to turn off file generation via params flag. By default, if flag is not set, backfill files are generated. Local params template sets flag to false (backfill files not generated), and production params template sets flag to true.

Changelog

  • changehc, quidel_covidtest, and claims_hosp backfill file generation to be enclosed in if statement

Fixes

Closes #1797

@nmdefries nmdefries requested a review from jingjtang March 21, 2023 15:03
@nmdefries nmdefries changed the title Allow user to turn of backfill corrections file generation Allow user to turn off backfill corrections file generation Mar 21, 2023
@nmdefries
Copy link
Contributor Author

@M5Skid @neul3 Let me know if this change looks good for you, or if you have any specific feedback.

@M5Skid
Copy link
Contributor

M5Skid commented Mar 21, 2023

It looks good to me, and should be pretty useful for local runs

Copy link
Contributor

@jingjtang jingjtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmdefries
Copy link
Contributor Author

@krivard This is ready to merge

@krivard krivard merged commit b44e22c into main Mar 27, 2023
@krivard krivard deleted the ndefries/backfill/on-off-switch branch March 27, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Backfill corrections] Let user toggle backfill corrections input file generation

5 participants