FlaSH Timeout Code in Runner not running FlaSH #1800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krivard
reviewed
Feb 28, 2023
Contributor
Author
|
I added the changes we discussed about threading & downloading files from AWS! |
krivard
suggested changes
Mar 22, 2023
Contributor
krivard
left a comment
krivard
left a comment
There was a problem hiding this comment.
Mostly documentation updates. The functionality changes look good!
Comment on lines
429
to
430
| None if remote | ||
| Locally returns past 7 days and the all outliers dataframe |
Contributor
There was a problem hiding this comment.
question: aren't past 7 days and outliers returned regardless of local/remote?
(there's no if not local guarding the process_params return at L417)
_delphi_utils_python/tests/flash_ref/confirmed_incidence_num/last_7_1.csv
Show resolved
Hide resolved
Co-authored-by: Katie Mazaitis <[email protected]>
Contributor
Author
Thank you for these suggestions! I think they should be reflected in the code now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlaSH threading Timer function prevents the function from running for x amt. of time, and thus doesn't function as a timeout. The following changes should have the flash module time out appropciately