safegraph: standardizing signal names #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishakha1812
changed the title
vishakha1812
force-pushed
the
rename_signals
branch
2 times, most recently
from
ae0e3f2 to
9e398ae
Compare
13 tasks
amartyabasu
reviewed
Aug 5, 2020
amartyabasu
reviewed
Aug 5, 2020
amartyabasu
reviewed
Aug 5, 2020
amartyabasu
reviewed
Aug 5, 2020
krivard
reviewed
Aug 6, 2020
krivard
suggested changes
Aug 6, 2020
vishakha1812
force-pushed
the
rename_signals
branch
2 times, most recently
from
b3753f1 to
ba64ad4
Compare
vishakha1812
force-pushed
the
rename_signals
branch
from
06e4544 to
b6d8b7b
Compare
…name() --> add_prefix() for better readability
…n.py and process.py
Kmm/rename signals
* Also converted unit test to test the process.py logic instead of the validity of the params file. * Corrected errors I'd introduced in the conversion to covidcast client
Corrected logic to comply with #113
krivard
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip_signalinparams.jsoncan takeTrue | False or '' or [] | List[str]:if
True,wip_will be added to all the the signals.if
Falseor"",wip_will be added to only signals that have never been published.if
[], it wont be adding any prefix to any of the signals. It might also work for someone who just wants to run the pipeline.If we want to have only some of the signals as
wipsignals, we can pass it towip_signalin the form of a list.