[fb-package] remove trailing space in B13 name #1072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capnrefsmmat
approved these changes
Jun 14, 2021
Contributor
capnrefsmmat
left a comment
capnrefsmmat
left a comment
There was a problem hiding this comment.
Looks good to me, provided the tests pass
Contributor
Author
|
@krivard This is ready to deploy. |
Contributor
|
Merged, pulled, built, installed. This update will run tomorrow morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wave 11 included a trailing space in item B13's name ("B13 "). We want it to be "B13" -- and the code refers to it as such -- so rename in code, change on the Qualtrics side to follow.
Changelog
bodgefunction to rename "B13 " to "B13".Implications
Because the code erroneously refers to this item as "B13", it has not been included in the microdata since Wave 11 was deployed. We will need to reissue the microdata going back to the Wave 11 release date (May 19) @krivard