Skip to content
This repository was archived by the owner on Sep 27, 2019. It is now read-only.
This repository was archived by the owner on Sep 27, 2019. It is now read-only.

EXPLAIN handle push down #1350

@ChTimTsubasa

Description

@ChTimTsubasa

The way #1108 add support to EXPLAIN is to extract the explained statement directly from query string at protocol handler layer, which is not the best place to handle EXPLAIN for 2 reasons:

  1. Pointed out by @nappelson, Support for EXPLAIN statement #1108 only support EXPLAIN for Postgres Simple Protocol and would fail Postgres Extended Protocol used by JDBC. This is because Optimizer does not support handling EXPLAIN.

  2. Protocol handler should only handle logic to protocol-specific things such as packet format serializing and deserializing. This is also true for PREPARE and EXECUTE, which would be pushed down too in a later fix.

The correct way to do this is to push down the logic on optimizer and let it identify the special statements and report to traffic_cop and traffic_cop should schedule special treatments to those plans.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions