Fix cmderdev/cmder#3020; hg prompt is slow. #3021
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cmder's hg prompt didn't use async prompt filtering yet.
Cmder's svn prompt only used async prompt filtering if a special config
variable was set (the commit which contributed it seems to have
misunderstood the git config settings for the git async prompt).
This commit makes the following changes:
1. Adds async prompt filtering for hg.
2. Makes async prompt filtering for svn the default.
3. Removes the prompt_overrideSvnStatusOptIn variable.
4. Fixes a bug where any errors during `svn status` in the svn prompt
accidentally show up in the terminal.
5. Fixes a bug where any errors during `hg branch` in the hg prompt
turn into Lua errors.
6. Simplifies the code for colors in the hg and svn prompts.
7. Clean up the svn prompt code and make it consistent with the git
and hg prompt code.
|
I tested these changes locally in a git dir, a hg dir, a svn dir, and a normal dir (no source control repo). |
Open
2 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
If the hg program is not found, then there used to be a Lua script error. I fixed that in the earlier commit in this PR. But the fix was incomplete, and the hg prompt still appended " ()" instead of not appending anything (which is how the svn prompt behaves when the svn program is not found).
|
I installed Mercurial and Subversion and did some deeper testing of the Cmder prompt for both. I found one additional pre-existing bug, so I added a fix into this PR as well. If the hg program isn't found, then the hg prompt was appending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cmder's hg prompt didn't use async prompt filtering yet.
Cmder's svn prompt only used async prompt filtering if a special config variable was set (the commit which contributed it seems to have misunderstood the git config settings for the git async prompt).
This commit makes the following changes:
svn statusin the svn prompt accidentally show up in the terminal.hg branchin the hg prompt turn into Lua errors.