-
-
Notifications
You must be signed in to change notification settings - Fork 3
Description
Hello everyone, I was planning to run the tests on PHP 8.3 and update the test suite. Afterwards I wanted to finish the typo fixes as seen in #14 and link both pull request to each other. Unfortunately, I encountered two errors while pushing the changes to GitHub. The errors appeared as follows:
Clue\Tests\React\ClickHouse\FunctionalClickHouseClientTest::testInsertStreamIntoTemporaryTableWithDataWillEmitCloseWithoutError
Failed asserting that true is false.
During one of the tests where we inserting a random table, we were expecting to be unable to write to the db, which should've returned a false instead of true (seen in the last line of the test were the error is thrown):
$db = new ClickHouseClient(getenv('URL'));
$db = $db->withSession();
$promise = $db->queryAsync('CREATE TEMPORARY TABLE asd123 (a UInt8) Engine = Memory');
await($promise);
$stream = $db->insertStream('asd123');
$this->assertInstanceOf(WritableStreamInterface::class, $stream);
$ret = $stream->write(['a' => 1]);
$this->assertFalse($ret);
The last pull request in this project was merged back in May with a green test suite. We haven't change anything ever since, so we didn't actively break the test suite here. After talking with @clue and @SimonFrings about this, we initially thought, that one of our dependencies changed in the meantime and is know causing the failing tests. We tried to downgrade some dependencies like promise-stream, async and promise without finding the cause. Perhaps the problem lies in the other dependencies, we have yet to check this. It could also be the case that there is an issue with the image itself.
Happy about input on this, I'll update this ticket as we make progress. 👍