feat(terraform): add database_insights_mode variable

[RoseSecurity]

what

• Upgrade rds-cluster module to v2.3.0 and introduce the database_insights_mode variable to support configuring RDS cluster insights mode. Adds validation for allowed values ("standard", "advanced") and updates module usage accordingly.

why

This pull request updates the Aurora PostgreSQL cluster module and adds support for configuring the database_insights_mode for RDS clusters. The main changes introduce a new variable to control the insights mode and update the module version to ensure compatibility.

references

• Module Update

Summary by CodeRabbit

• Chores

  • Updated Aurora PostgreSQL cluster module to v2.3.0.

• New Features

  • Added a configurable "database insights mode" option (supports "standard" and "advanced") to select the level of RDS database monitoring and insights.

[coderabbitai]

Walkthrough

Bumps the aurora_postgres_cluster module from v2.2.0 to v2.3.0 and adds a new Terraform variable database_insights_mode, wired into the module as database_insights_mode = var.database_insights_mode.

Changes

Cohort / File(s)	Summary
Aurora Postgres Cluster Configuration src/cluster-regional.tf	Module version updated from 2.2.0 → 2.3.0; added input database_insights_mode = var.database_insights_mode.
Variable Definitions src/variables.tf	Added variable database_insights_mode (type: string, default: null) with validation restricting values to "standard" or "advanced" and descriptive docs link.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Focus review on variable validation and correct wiring to module input.
• Check module v2.3.0 release notes for any behavioral changes.

Possibly related PRs

• feat: support RDS-managed admin password via Secrets Manager #64 — Adds and wires new public inputs to the same aurora_postgres_cluster module block (similar module-interface changes).

Suggested labels

needs-test

Suggested reviewers

• goruha

Poem

🐰 I hopped through the vars and gave them a name,
database_insights_mode now joins the game.
Version bumped onward, the cluster sings bright,
Standard or advanced — choose what feels right. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "feat(terraform): add database_insights_mode variable" directly and clearly summarizes the primary change in the changeset. The PR introduces a new Terraform variable to enable database insights mode configuration for Aurora PostgreSQL clusters, which is the user-facing functionality this PR delivers. While the changeset also includes a module version upgrade from 2.2.0 to 2.3.0, this is a supporting dependency change that enables the variable addition rather than the main objective. The title is concise, specific, and avoids vague language, making it immediately clear to someone reviewing the PR history what the change accomplishes.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch add-database-insights-mode

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1fece0f and 373e260.

📒 Files selected for processing (1)

• src/variables.tf (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/variables.tf

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Summary

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 459512d and 1fece0f.

📒 Files selected for processing (2)

• src/cluster-regional.tf (2 hunks)
• src/variables.tf (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

src/@(main|variables|outputs|providers|versions|context).tf

📄 CodeRabbit inference engine (AGENTS.md)

Keep the Terraform component source of truth under src/ with canonical files: main.tf, variables.tf, outputs.tf, providers.tf, versions.tf, context.tf

Files:

• src/variables.tf

src/**/*.tf

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.tf: Terraform code must be formatted (terraform fmt -recursive) and free of lint violations (TFLint rules)
Use lower_snake_case for Terraform variables and locals; keep resource and data source names descriptive and aligned with Cloud Posse null-label patterns
Use 2-space indentation for Terraform files

Files:

• src/variables.tf
• src/cluster-regional.tf

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Summary

🔇 Additional comments (2)

src/cluster-regional.tf (2)

8-8: Module version upgrade is appropriate.

The version bump to 2.3.0 correctly enables support for the new database_insights_mode input parameter. This is consistent with the changes made to variables.tf.

---

42-42: Module input pass-through is correct (pending fix in variables.tf).

The module input assignment is syntactically sound and properly positioned within the resource configuration. However, ensure the validation issue flagged in src/variables.tf (lines 202-205) is resolved before deployment, as it will block module instantiation with the default value.

[RoseSecurity]

/terratest

[github-actions]

These changes were released in v1.540.4.