chore(deps): update terraform cloudposse/rds-cluster/aws to v1.18.0 #4

renovate · 2024-12-04T08:46:22Z

This PR contains the following updates:

Package	Type	Update	Change
cloudposse/rds-cluster/aws (source)	module	minor	`1.3.2` -> `1.18.0`

Release Notes

cloudposse/terraform-aws-rds-cluster (cloudposse/rds-cluster/aws)

`v1.18.0`

Compare Source

fix: Add perfomance inside to primary cluster @djakielski (#250)

what

Add performace inside config also on primary cluster

why

had issues with incompatible cluster and instance parameter
you can enable performance inside on cluster

references

https://registry.terraform.io/providers/hashicorp/aws/5.82.2/docs/resources/rds_cluster#performance_insights_enabled-1

`v1.17.0`

Compare Source

fix: reserved instances, aurora rds specifics @oycyc (#249)

what

RDS Reserved Instances multi AZ mode is never available for Aurora engines, see images on the console - this PR checks to ensure that it is set to false if the engine is Aurora:

fix: reserved instance multi_az setting @oycyc (#248)

what

Using local.is_regional_cluster to determine whether or not it is Multi-AZ is not accurate. local.is_regional_cluster only checks if var.cluster_type == "regional", which determines if this is a regional vs global cluster

I could have a regional cluster, but it is NOT multi-az. One determining factor is how many instances in the cluster, if ever more than 1 in a single cluster, then it has to be in multiple AZs. https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.MultiAZ.html

why

If I have a regional cluster, this thinks that it's ALWAYS multi-az, which is not true.

references

https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.MultiAZ.html

`v1.15.1`

Compare Source

🚀 Enhancements

fix: reserved instances restrictions @oycyc (#244)

what

This conditional check on whether or not to enable reserved instances is too restrictive. contains(["mysql", "postgresql"], local.reserved_instance_engine) is saying that only allow it if it is MySQL or PostgreSQL.

I think contains was originally meant to be like in the literal sense of "contains". Since in my case, I'm using aurora-postgresql, and it fails this check, yet it is one of the options for reserved instances.

why

endswith might be better, but it is TOO restrictive, seeing that there's so many options.

Additionally, Terraform will fail if user specifies the wrong engine type. There's no need for this check.

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/rds_reserved_instance_offering

🐛 Bug Fixes

fix: reserved instances restrictions @oycyc (#244)

what

This conditional check on whether or not to enable reserved instances is too restrictive. contains(["mysql", "postgresql"], local.reserved_instance_engine) is saying that only allow it if it is MySQL or PostgreSQL.

I think contains was originally meant to be like in the literal sense of "contains". Since in my case, I'm using aurora-postgresql, and it fails this check, yet it is one of the options for reserved instances.

why

endswith might be better, but it is TOO restrictive, seeing that there's so many options.

Additionally, Terraform will fail if user specifies the wrong engine type. There's no need for this check.

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/rds_reserved_instance_offering

`v1.15.0`

Compare Source

🚀 Enhancements

Implement and close #237 (add option for local write forwarding) Thank you @Junaid-Tem
Implement and close #239 (allow the configuration of reservation_id for aws_rds_reserved_instance) Thank you @oycyc

🐛 Bug Fixes

Partly revert #236 (see discussion below). Closes #241

Multiple cleanups @Nuru (#242)

what

Partly revert #236 (see discussion below)
Allow explicitly naming parameter group
Use full name of engine for reserved DB instances
Implement and close #197
Implement and close #199
Implement and close #230 Thank you @raymondchen625

why

Closes #241
Closes #225
Instance engine should match cluster engine
Consolidate PRs

discussion: why partially revert #236?

PR #236 enhanced the random_pet that determines part of the name of the DB instances so that the name would change whenever the instances would need to be recreated. Unfortunately, as a side-effect, that causes all instances created with earlier versions of this module to be replaced.

Upon further investigation, it was determined that all the "keepers" added by the PR would also force the cluster to be replaced. Unlike replacing an instance, replacing the cluster results in data loss. Also, unless you change the name of the cluster, the module both before and after the PR would fail, because it would try to create a new cluster with the same name before destroying the old cluster.

We prefer this failure mode, requiring the user to explicitly destroy the cluster before creating the new one, because it puts the user on notice about the potential data loss. So given that the changes in the PR did not make something work that did not work before, and it did cause disruption, we reverted the change to the keepers.

`v1.14.0`

Compare Source

fix: reserved instance output @oycyc (#240)

what

Fix the output

How it will look with this:

why

It does not need to be a join with a [*] this will cause error, just referring to it with the resource name will output everything as one object.

references

See the Terraform provider docs https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_reserved_instance#attribute-reference

`v1.13.0`

Compare Source

Output instance endpoints, add attributes to `random_pet` that force a new instance @finchr (#236)

…new instance

what

output instance endpoints
add aws_rds_cluster_instance attributes that force a new instance to the randmon_pet resource.

why

I need the actual instance endpoints for the Datadog DMS integration, the default dashboards work better with the exact instance identifier.
Currently if any of these attributes change (db_subnet_group_name, engine) it will bypass the random_pet and attempt to create instances with the same identifier.

references

`v1.12.0`

Compare Source

bug/193-enable-http-endpoint @tsaucier0 (#234)

what

Support for serverless v2 to ensure that configurations (like HTTP endpoints for the Data API) are correctly enabled on instances using the serverless v2 implementation.
A new condition, is_serverless_v2, was introduced to identify serverless v2 instances based on the specific configuration parameters required for its activation.

why

The original code was intended to enable_http_endpoint based on whether the database instance was using serverless architecture. With the introduction of serverless v2 for certain database engines, there is a need to update the logic to accommodate these options.

references

Closes #193

`v1.11.4`

Compare Source

🐛 Bug Fixes

fix(reserved instances): use var.instance_type to determine RI offering instead of optional db_instance_class var @kevcube (#235)

the var `db_instance_class` isn't required, so won't always be available. `instance_type` is required.

`v1.11.3`

Compare Source

feat: support reserved instances @kevcube (#233)

questions

do we want to allow customization of the count/size of reserved instances?

🤖 Automatic Updates

Update terratest to '>= 0.46.0' @osterman (#215)

what

Update terratest >= 0.46.0

why

Support OpenTofu for testing

References

https://github.com/gruntwork-io/terratest/releases/tag/v0.46.0
DEV-374 Add opentofu to all our Terragrunt Testing GHA matrix

`v1.11.2`

Compare Source

Dual stack support @ngoyal16 (#231)

what

RDS cluster can be run in two network modes - IPV4 or DUAL.
Underlying module already supports this parameter

why

It can be mandatory to enable it to be able to connect from ipv6 only runtimes

references

Closes #175

🤖 Automatic Updates

Migrate new test account @osterman (#232)

what

Update .github/settings.yml
Update .github/chatops.yml files

why

Re-apply .github/settings.yml from org level to get terratest environment
Migrate to new test account

References

DEV-388 Automate clean up of test account in new organization
DEV-387 Update terratest to work on a shared workflow instead of a dispatch action
DEV-386 Update terratest to use new testing account with GitHub OIDC

Update .github/settings.yml @osterman (#229)

what

Update .github/settings.yml
Drop .github/auto-release.yml files

why

Re-apply .github/settings.yml from org level
Use organization level auto-release settings

references

DEV-1242 Add protected tags with Repository Rulesets on GitHub

Update .github/settings.yml @osterman (#228)

what

Update .github/settings.yml
Drop .github/auto-release.yml files

why

Re-apply .github/settings.yml from org level
Use organization level auto-release settings

references

DEV-1242 Add protected tags with Repository Rulesets on GitHub

`v1.11.1`

Compare Source

🚀 Enhancements

fix: Too long identifier name error @MaxymVlasov (#226)

what

Fix too long identifier name without cluster recreation:

set id_length_limit = 40 for

module "aurora" {
  source  = "cloudposse/rds-cluster/aws"
  version = "1.10.0"
  ...
  id_length_limit = 40
}

will cause such recreation if final module.this.id will be between 40-60 characters

why

https://github.com/cloudposse/terraform-aws-rds-cluster/releases/tag/1.10.0 introduced random_pet, which adds 2 extra words on the top of module.this.id, and that exceed limit of 63 allowed characters for RDS names

╷
│ Error: creating RDS Cluster (company-staging-aurora-payments-ledger-service-aliases) Instance (company-staging-aurora-payments-ledger-service-aliases-promoted-piglet-1): operation error RDS: CreateDBInstance, https response error StatusCode: 400, RequestID: 1979b42f-b1df-4e00-b0ec-d3b629b3002d, api error InvalidParameterValue: Invalid database identifier:  company-staging-aurora-payments-ledger-service-aliases-promoted-piglet-1
│ 
│   with module.aurora_aliases.aws_rds_cluster_instance.default[0],
│   on .terraform/modules/aurora_aliases/main.tf line 261, in resource "aws_rds_cluster_instance" "default":
│  261: resource "aws_rds_cluster_instance" "default" {

This PR limit final identifier to 62-63 chars (depends on count of replica)

references

Fixing https://github.com/cloudposse/terraform-aws-rds-cluster/pull/213

🐛 Bug Fixes

fix: Too long identifier name error @MaxymVlasov (#226)

what

Fix too long identifier name without cluster recreation:

set id_length_limit = 40 for

module "aurora" {
  source  = "cloudposse/rds-cluster/aws"
  version = "1.10.0"
  ...
  id_length_limit = 40
}

will cause such recreation if final module.this.id will be between 40-60 characters

why

https://github.com/cloudposse/terraform-aws-rds-cluster/releases/tag/1.10.0 introduced random_pet, which adds 2 extra words on the top of module.this.id, and that exceed limit of 63 allowed characters for RDS names

╷
│ Error: creating RDS Cluster (company-staging-aurora-payments-ledger-service-aliases) Instance (company-staging-aurora-payments-ledger-service-aliases-promoted-piglet-1): operation error RDS: CreateDBInstance, https response error StatusCode: 400, RequestID: 1979b42f-b1df-4e00-b0ec-d3b629b3002d, api error InvalidParameterValue: Invalid database identifier:  company-staging-aurora-payments-ledger-service-aliases-promoted-piglet-1
│ 
│   with module.aurora_aliases.aws_rds_cluster_instance.default[0],
│   on .terraform/modules/aurora_aliases/main.tf line 261, in resource "aws_rds_cluster_instance" "default":
│  261: resource "aws_rds_cluster_instance" "default" {

This PR limit final identifier to 62-63 chars (depends on count of replica)

references

Fixing https://github.com/cloudposse/terraform-aws-rds-cluster/pull/213

`v1.11.0`

Compare Source

feat: manage master credentials in secrets manager @pazaan (#221)

what

Allow to manage master credentials in Secrets Manager

why

Managed secrets are more secure and easy to use.

references

closes https://github.com/cloudposse/terraform-aws-rds-cluster/issues/166
Duplicate of https://github.com/cloudposse/terraform-aws-rds-cluster/pull/218, but that PR looks like it's gone stale. I pushed the same fixes to the original branch as well, in case @salemgolemugoo wanted to push them forward to Pull 218, but that hasn't had any activity either.

`v1.10.2`

Compare Source

🚀 Enhancements

fix: pass var.db_port to RDS cluster instances @emmanuelchibuogwu (#222)

what

Currently, the var.db_port variable is not passed to both aws_rds_cluster resources.

why

var.db_port is passed to the security group but not the cluster instances, this results to the following cases:

setting var.db_port to a value other than the default makes the cluster inaccessible .
No way to expose the RDS cluster on a different port

references

🐛 Bug Fixes

fix: pass var.db_port to RDS cluster instances @emmanuelchibuogwu (#222)

what

Currently, the var.db_port variable is not passed to both aws_rds_cluster resources.

why

var.db_port is passed to the security group but not the cluster instances, this results to the following cases:

setting var.db_port to a value other than the default makes the cluster inaccessible .
No way to expose the RDS cluster on a different port

references

`v1.10.1`

Compare Source

🚀 Enhancements

Fix conflicting `restore_to_point_in_time` attributes @ericluria (#217)

what

Fixes handling of use_latest_restorable_time and restore_to_time while preserving existing default values for backwards compatibility

why

Original attempt at fixing this (https://github.com/cloudposse/terraform-aws-rds-cluster/pull/216) was insufficient

references

Follow-up to original attempt: https://github.com/cloudposse/terraform-aws-rds-cluster/pull/216
Correctly fixes https://github.com/cloudposse/terraform-aws-rds-cluster/issues/163

🐛 Bug Fixes

Fix conflicting `restore_to_point_in_time` attributes @ericluria (#217)

what

Fixes handling of use_latest_restorable_time and restore_to_time while preserving existing default values for backwards compatibility

why

Original attempt at fixing this (https://github.com/cloudposse/terraform-aws-rds-cluster/pull/216) was insufficient

references

Follow-up to original attempt: https://github.com/cloudposse/terraform-aws-rds-cluster/pull/216
Correctly fixes https://github.com/cloudposse/terraform-aws-rds-cluster/issues/163

`v1.10.0`

Compare Source

reopen #192 @finchr (#213)

what
I implemented create_before_destroy on the aws_rds_cluster_instance default instances.
Originally in #192 but that was closed for reasons we won't go into here.

why
Making a change to any parameter that triggers a replace on a aws_rds_cluster_instance results in all instances being destroyed before attempting to create a new instance which causes an outage. This a faster (and safer) altenative to https://github.com/cloudposse/terraform-aws-rds-cluster/pull/191

references
This closes https://github.com/cloudposse/terraform-aws-rds-cluster/issues/190 and is an alternative to https://github.com/cloudposse/terraform-aws-rds-cluster/pull/191

`v1.9.1`

Compare Source

Support restoring to a specific time @ericluria (#216)

what

Adds restore_to_time as an attribute of the restore_to_point_in_time parameter, allowing to restore to a specific datetime rather than the latest restorable time.

why

Fixes missing functionality that's supported by the aws_rds_cluster resource.

references

Closes #163

questions

I noticed while making this PR that source_cluster_identifier defaults to "120m", which looks like an inadvertent copy-and-paste from another parameter. In the aws_rds_cluster resource, this parameter is required, so it doesn't make sense to have a default anyway. Would you recommend leaving this parameter as-is, or should we fix it?

edit: fixed as part of this PR

🤖 Automatic Updates

Update release workflow to allow pull-requests: write @osterman (#214)

what

Update workflow (.github/workflows/release.yaml) to have permission to comment on PR

why

So we can support commenting on PRs with a link to the release

Update GitHub Workflows to use shared workflows from '.github' repo @osterman (#212)

what

Update workflows (.github/workflows) to use shared workflows from .github repo

why

Reduce nested levels of reusable workflows

Update GitHub Workflows to Fix ReviewDog TFLint Action @osterman (#211)

what

Update workflows (.github/workflows) to add issue: write permission needed by ReviewDog tflint action

why

The ReviewDog action will comment with line-level suggestions based on linting failures

Update GitHub workflows @osterman (#210)

what

Update workflows (.github/workflows/settings.yaml)

why

Support new readme generation workflow.
Generate banners

Use GitHub Action Workflows from `cloudposse/.github` Repo @osterman (#207)

what

Install latest GitHub Action Workflows

why

Use shared workflows from cldouposse/.github repository
Simplify management of workflows from centralized hub of configuration

`v1.9.0`

Compare Source

add option for enabling global write forwarding @tdockseydt (#186)

what

Add option for enabling global write forwarding for aws rds cluster.

why

Ability to enable global write forwarding across our aws rds clusters.
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/aurora-global-database-write-forwarding-apg.html
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_cluster#enable_global_write_forwarding

🤖 Automatic Updates

Bump google.golang.org/grpc from 1.51.0 to 1.56.3 in /test/src @dependabot (#204)

Bumps google.golang.org/grpc from 1.51.0 to 1.56.3.

Release notes

Sourced from google.golang.org/grpc's releases.

Release 1.56.3

Security

server: prohibit more than MaxConcurrentStreams handlers from running at once (CVE-2023-44487)

In addition to this change, applications should ensure they do not leave running tasks behind related to the RPC before returning from method handlers, or should enforce appropriate limits on any such work.

Release 1.56.2

status: To fix a panic, status.FromError now returns an error with codes.Unknown when the error implements the GRPCStatus() method, and calling GRPCStatus() returns nil. (#6374)

Release 1.56.1

client: handle empty address lists correctly in addrConn.updateAddrs

Release 1.56.0

New Features

client: support channel idleness using WithIdleTimeout dial option (#6263)

This feature is currently disabled by default, but will be enabled with a 30 minute default in the future.

client: when using pickfirst, keep channel state in TRANSIENT_FAILURE until it becomes READY (gRFC A62) (#6306)

xds: Add support for Custom LB Policies (gRFC A52) (#6224)

xds: support pick_first Custom LB policy (gRFC A62) (#6314) (#6317)

client: add support for pickfirst address shuffling (gRFC A62) (#6311)

xds: Add support for String Matcher Header Matcher in RDS (#6313)

xds/outlierdetection: Add Channelz Logger to Outlier Detection LB (#6145)

Special Thanks: @s-matyukevich

xds: enable RLS in xDS by default (#6343)

orca: add support for application_utilization field and missing range checks on several metrics setters

balancer/weightedroundrobin: add new LB policy for balancing between backends based on their load reports (gRFC A58) (#6241)

authz: add conversion of json to RBAC Audit Logging config (#6192)

authz: add support for stdout logger (#6230 and #6298)

authz: support customizable audit functionality for authorization policy (#6192 #6230 #6298 #6158 #6304 and #6225)

Bug Fixes

orca: fix a race at startup of out-of-band metric subscriptions that would cause the report interval to request 0 (#6245)

xds/xdsresource: Fix Outlier Detection Config Handling and correctly set xDS Defaults (#6361)

xds/outlierdetection: Fix Outlier Detection Config Handling by setting defaults in ParseConfig() (#6361)

API Changes

orca: allow a ServerMetricsProvider to be passed to the ORCA service and ServerOption (#6223)

Release 1.55.1

status: To fix a panic, status.FromError now returns an error with codes.Unknown when the error implements the GRPCStatus() method, and calling GRPCStatus() returns nil. (#6374)

Release 1.55.0

Behavior Changes

xds: enable federation support by default (#6151)

status: status.Code and status.FromError handle wrapped errors (#6031 and #6150)

... (truncated)

Commits

1055b48 Update version.go to 1.56.3 (#6713)
5efd7bd server: prohibit more than MaxConcurrentStreams handlers from running at once...
bd1f038 Upgrade version.go to 1.56.3-dev (#6434)
faab873 Update version.go to v1.56.2 (#6432)
6b0b291 status: fix panic when servers return a wrapped error with status OK (#6374) ...
ed56401 [PSM interop] Don't fail target if sub-target already failed (#6390) (#6405)
cd6a794 Update version.go to v1.56.2-dev (#6387)
5b67e5e Update version.go to v1.56.1 (#6386)
d0f5150 client: handle empty address lists correctly in addrConn.updateAddrs (#6354) ...
997c1ea Change version to 1.56.1-dev (#6345)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the Security Alerts page.

Add GitHub Settings @osterman (#200)

what

Install a repository config (.github/settings.yaml)

why

Programmatically manage GitHub repo settings

Add GitHub Settings @osterman (#198)

what

Install a .github/settings.yaml

why

Programmatically manage GitHub repo settings

Update README.md and docs @cloudpossebot (#195)

what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates

Update Scaffolding @osterman (#196)

what

Reran make readme to rebuild README.md from README.yaml
Migrate to square badges
Add scaffolding for repo settings and Mergify

why

Upstream template changed in the .github repo
Work better with repository rulesets
Modernize look & feel

Update Terraform cloudposse/dynamic-subnets/aws to v2.4.2 @renovate (#194)

This PR contains the following updates:

Package	Type	Update	Change
cloudposse/dynamic-subnets/aws (source)	module	patch	`2.4.1` -> `2.4.2`

Release Notes

cloudposse/terraform-aws-dynamic-subnets (cloudposse/dynamic-subnets/aws)

`v2.4.2`

Compare Source

🚀 Enhancements

chore(deps): update terraform cloudposse/utils/aws to v1.4.0 (main) @renovate (#191)

This PR contains the following updates:

Package	Type	Update	Change
cloudposse/utils/aws (source)	module	minor	`1.3.0` -> `1.4.0`

Release Notes

cloudposse/terraform-aws-utils (cloudposse/utils/aws)

`v1.4.0`

Compare Source

Add il-central-1 region @&#8203;jasonmk (#&#8203;31)

what

Add new Tel Aviv (il-central-1) region

why

Provide full coverage

references

Sync github @&#8203;max-lobur (#&#8203;27)

Rebuild github dir from the template

🤖 Automatic Updates

chore(deps): update terraform cloudposse/utils/aws to v1.4.0 (main) @renovate (#191)

This PR contains the following updates:

Package	Type	Update	Change
cloudposse/utils/aws (source)	module	minor	`1.3.0` -> `1.4.0`

Release Notes

cloudposse/terraform-aws-utils (cloudposse/utils/aws)

`v1.4.0`

Compare Source

Add il-central-1 region @&#8203;jasonmk (#&#8203;31)

what

Add new Tel Aviv (il-central-1) region

why

Provide full coverage

references

Sync github @&#8203;max-lobur (#&#8203;27)

Rebuild github dir from the template

Update README.md and docs @cloudpossebot (#189)

what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates

`v1.8.0`

Compare Source

implement simple rolling update using depends_on @finchr (#191)

what

Implement a simple rolling update for the aws_rds_cluster_instance default instances.

why

To implement a zero downtime deploy for simple changes.

references

closes #190

`v1.7.1`

Compare Source

Allow to configure storage type for global databases @bentmann (#189)

what

Use existing storage_type variable for global DBs, too. Currently, it is only set for regional clusters.

why

Aurora clusters offer two different storage types, standard and I/O-Optimized. Which one is employed for clusters in a global DB should be configurable to be able to realize cost savings that I/O-Optimized offers for certain workloads.

references

🤖 Automatic Updates

Update README.md and docs @cloudpossebot (#187)

what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates

`v1.7.0`

Compare Source

Add serverlessv2 config to aws_rds_cluster.secondary @asmithdt (#181)

what

Add missing config to aws_rds_cluster.secondary

why

Error: creating RDS Cluster (<redacted>) Instance (<redacted>): InvalidDBClusterStateFault: Set the Serverless v2 scaling configuration on the parent DB cluster before creating a Serverless v2 DB instance.
│       status code: 400, request id:

Tested on my cluster and confirmed to work when a serverless configuration is provided.

`v1.6.0`

Compare Source

Add `parameter_group_name_prefix_enabled` variable. Update examples and tests @aknysh (#179)

what

Add parameter_group_name_prefix_enabled variable (defaults to true to maintain the current functionality)
Allow using both the name and name_prefix attributes in aws_rds_cluster_parameter_group and aws_db_parameter_group resources
Update tests to the latest versions
Update examples to use the corerct combinations of DB instance classes and DB engine versions

why

Allow updating old Aurora clusters, which were provisioned with the old versions of the module, to the latest version of the module without rebooting the DB instances. Old clusters, provisioned with the old versions of the module, use the name attribute (which was the only option in the old versions of the module) instead of name_prefix attribute
Updating the parameter group causes the DB instance to reboot, which could cause a downtime. Depending on the size of the database, the downtime could take some amount of time not suitable for production clusters (after reboot, the database will go through all the recovery points and logs, and depending on the database size, it could take some time)

When you associate a new DB parameter group with a DB instance, 
the modified static and dynamic parameters are applied only after the DB instance is rebooted. 
However, if you modify dynamic parameters in the DB parameter group after you associate it with the DB instance, 
these changes are applied immediately without a reboot.

references

https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Overview.DBInstance.Modifying.html

Support AWS Provider V5 @max-lobur (#170)

what

Support AWS Provider V5
Linter fixes

why

Maintenance

references

https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0

Sync github @max-lobur (#167)

Rebuild github dir from the template

`v1.5.0`

Compare Source

No changes

`v1.4.0`

Compare Source

Support for Activity Stream added @ngoyal16 (#159)

what

Allow to create Activity Stream for RDS Cluster

Added by @nuru:

Move PostgreSQL testing to proper test region (us-east-2)
Fix expected subnet CIDR due to fewer availability zones in us-east-2 than us-east-1
Increase test parallelism so that tests complete in under 60 minutes

why

Can be used to enable and activity stream from the cluster module itself

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

mergify · 2024-12-04T08:47:00Z

/terratest

coderabbitai · 2024-12-20T16:36:15Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

mergify · 2024-12-20T16:36:44Z

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require terratest

This rule is failing.

This rule require terratest status

check-success = test/terratest

mergify · 2025-01-19T16:37:27Z