-
Notifications
You must be signed in to change notification settings - Fork 47
feat(docs): add section about bumping Cluster
imageName
using renovate
#330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8cf8316
to
c3d2972
Compare
I've been running this against CNPG tags and hit two practical issues with the current snippet:
Also, it helps to add a Proposed doc snippet (drop-in): {
customManagers: [
{
// CloudNativePG Cluster imageName
customType: "regex",
description: ["Process CloudnativePG Postgresql version"],
managerFilePatterns: ["/\\.ya?ml(?:\\.j2)?$/"],
matchStrings: [
"imageName:\\s*(?<depName>[^:\\s#]+):(?<currentValue>[^@\\s#]+)(?:@(?<currentDigest>sha256:[A-Fa-f0-9]{64}))?"
],
datasourceTemplate: "docker",
versioningTemplate: "regex:^(?<major>\\d+)\\.(?<minor>\\d+)-(?<patch>\\d+)(?:-(?<compatibility>\\S+))?$",
replaceStringTemplate: "imageName: {{depName}}:{{newValue}}{{#if newDigest}}@{{newDigest}}{{/if}}"
}
]
} Why this is safer:
|
@acuntex although your answer smells quite a bit AI (correct me if I'm wrong) I'm still going to address a few points. Firstly, this PR just adds an example renovate manager, so if you need something more specific feel free to adjust it in your config. The official file extension is I adapted the regex so that the digest is optional. By the way, if you don't want to do the entire work on your own at least check that what the LLM spat out is correct. |
@DerRockWolf I grabbed an older custom manager from my own repo as inspiration and shared my notes here to improve the user experience for folks configuring Renovate with CNPG. |
0dd6f59
to
f61291d
Compare
} | ||
``` | ||
|
||
Renovate will never change the `compatibility` part of the tag! So bumping from e.g., `trixie` to the next debian release must be done manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove the part about bumping 'trixie' to something else. The procedure to change the OS of the image is not straightforward and requires careful execution; simply changing the image is not enough.
Renovate will never change the `compatibility` part of the tag! So bumping from e.g., `trixie` to the next debian release must be done manually. | |
Renovate will never change the `compatibility` part of the tag, ensuring that the upgraded images will remain compatible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on that a bit? I thought that at some point after a new Debian release came out you will also provide images for this new version. What else would I as a user need to adapt in order to use the new OS?
…ovate Signed-off-by: RockWolf <[email protected]>
Signed-off-by: RockWolf <[email protected]>
f61291d
to
356443c
Compare
This regex manager example can be used by users of renovate that want to also automate updates of their CNPG clusters.
Resolves #257