Migrate dynatrace integration to LD_PRELOAD and support FIPS mode #1041

joushx · 2023-10-31T11:44:35Z

Migrate the dnytrace integration to use the LD_PRELOAD method as used within other buildpacks and support FIPS mode.

Set LD_PRELOAD environment variable instead of java options
Add option to enable FIPS cryptographic mode
adapt tests and test fixtures

linux-foundation-easycla · 2023-10-31T11:44:39Z

The committers listed above are authorized under a signed CLA.

✅ login: joushx / name: Johannes Mittendorfer (93226a3, a2f6d96, a42f608, 48d0e02, 0490c5d, 4b1f6ca)

anthonydahanne · 2023-11-10T15:02:46Z

lib/java_buildpack/framework/dynatrace_one_agent.rb

        technologies  = manifest['technologies']
-        java_binaries = technologies['java']['linux-x86-64']
-        loader        = java_binaries.find { |bin| bin['binarytype'] == 'loader' }
+        java_binaries = technologies['process']['linux-x86-64']


why change from java to process ?

The use of java is for historical reasons. process is now the default and also used in other buildpacks (e.g. https://github.com/Dynatrace/libbuildpack-dynatrace/blob/master/hook.go#L403)

anthonydahanne · 2023-11-10T15:03:13Z

lib/java_buildpack/framework/dynatrace_one_agent.rb


      def skip_errors?
-        credentials[SKIP_ERRORS].to_b
+        credentials[SKIP_ERRORS] == "true"


~~why ignoring credentials[SKIP_ERRORS] ?~~

sorry my mistake ; should be the same - why the change though?

We found that the method was not working in the way we expected it (see https://try.ruby-lang.org/playground/#code=class+String%0A++def+to_b%0A++++casecmp+'true'%0A++end%0Aend%0A%0Aif+%22false%22.to_b%0A++puts+%22yes%22%0Aend&engine=cruby-3.2.0).

Also, from my understanding it would match against "t" or other parts of "true". Which contradicts the information in our documentation.

ok, makes sense!

anthonydahanne · 2023-11-10T15:03:40Z

lib/java_buildpack/framework/dynatrace_one_agent.rb

+      end
+
+      def enable_fips?
+        credentials[ENABLE_FIPS] == "true"


~~same, why is it unconditional?~~

sorry my mistake - all is fine!

meibensteiner · 2023-11-22T09:30:19Z

@dmikusa @pivotal-david-osullivan Could you please take a look? We have some customers who want to switch to the updated buildpack by end of year.

dmikusa · 2023-11-28T18:03:41Z

@meibensteiner Hi, sorry for the delay. The PR looks OK but it has to go through some manual testing. Testing with the CF JBP is time-consuming, but helps ensure we don't have any regressions. Once that's done we'll move forward and get it merged. Thanks in advance for your patience.

TimGerlach · 2023-12-13T08:05:09Z

Hi @dmikusa ,
Have you had a chance to perform the manual testing that you mentioned previously? I'm asking because we are running a critical project that requires this PR to be merged before the end of this year.
We appreciate your support.

pivotal-david-osullivan · 2023-12-15T12:59:51Z

@TimGerlach
@anthonydahanne is working on this testing, we are aiming to get this out in a release next week!

anthonydahanne · 2023-12-19T19:35:24Z

@dmikusa , @pivotal-david-osullivan I could test this change, using:

  buildpacks:
    -  https://github.com/joushx/java-buildpack

and using my own Dynatrace trial account - everything still worked fine,see screenshots

You'll need to rebase this branch though before merging; it's pretty far behind now.

Thanks @joushx for your patience!

Migrate the dnytrace integration to use the LD_PRELOAD method as used within other buildpacks. * Set LD_PRELOAD environment variable instead of java options * adapt tests and test fixtures

This adds an option to enable FIPS mode if enablefips is set. OneAgent uses the FIPS mode to be compliant with the FIPS 140-3 computer security standard.

joushx · 2023-12-20T06:32:05Z

Nice, thank you! I just did the rebase.

lib/java_buildpack/framework/dynatrace_one_agent.rb

spec/java_buildpack/framework/dynatrace_one_agent_spec.rb

Co-authored-by: David O'Sullivan <[email protected]>

joushx · 2023-12-20T13:32:55Z

Linter suggestions applied

joushx changed the title ~~Migrate dynatrace integration to LD_PRELOAD~~ WIP: Migrate dynatrace integration to LD_PRELOAD Oct 31, 2023

joushx force-pushed the main branch 6 times, most recently from 49e08c2 to 955d616 Compare October 31, 2023 14:36

joushx changed the title ~~WIP: Migrate dynatrace integration to LD_PRELOAD~~ Migrate dynatrace integration to LD_PRELOAD and support FIPS mode Oct 31, 2023

joushx force-pushed the main branch from 955d616 to 21dee5f Compare October 31, 2023 14:51

Gerg requested review from anthonydahanne, dmikusa and pivotal-david-osullivan November 8, 2023 17:41

anthonydahanne reviewed Nov 10, 2023

View reviewed changes

jm-dt added 2 commits December 20, 2023 07:30

Migrate dynatrace integration to LD_PRELOAD

93226a3

Migrate the dnytrace integration to use the LD_PRELOAD method as used within other buildpacks. * Set LD_PRELOAD environment variable instead of java options * adapt tests and test fixtures

Enable FIPS mode when requested

a2f6d96

This adds an option to enable FIPS mode if enablefips is set. OneAgent uses the FIPS mode to be compliant with the FIPS 140-3 computer security standard.

joushx force-pushed the main branch from 21dee5f to a2f6d96 Compare December 20, 2023 06:30

pivotal-david-osullivan reviewed Dec 20, 2023

View reviewed changes

lib/java_buildpack/framework/dynatrace_one_agent.rb Outdated Show resolved Hide resolved

pivotal-david-osullivan reviewed Dec 20, 2023

View reviewed changes

lib/java_buildpack/framework/dynatrace_one_agent.rb Outdated Show resolved Hide resolved

pivotal-david-osullivan reviewed Dec 20, 2023

View reviewed changes

lib/java_buildpack/framework/dynatrace_one_agent.rb Outdated Show resolved Hide resolved

pivotal-david-osullivan reviewed Dec 20, 2023

View reviewed changes

spec/java_buildpack/framework/dynatrace_one_agent_spec.rb Outdated Show resolved Hide resolved

joushx and others added 3 commits December 20, 2023 14:32

Linter fixes

a42f608

Co-authored-by: David O'Sullivan <[email protected]>

Linter fixes

48d0e02

Co-authored-by: David O'Sullivan <[email protected]>

Linter fixes

0490c5d

Co-authored-by: David O'Sullivan <[email protected]>

Linter fixes

4b1f6ca

Co-authored-by: David O'Sullivan <[email protected]>

pivotal-david-osullivan approved these changes Dec 20, 2023

View reviewed changes

pivotal-david-osullivan merged commit 3d23111 into cloudfoundry:main Dec 20, 2023

anthonydahanne mentioned this pull request Jun 16, 2024

Move Anthony Dahanne to Buildpacks and Java tools approver cloudfoundry/community#899

Merged

Migrate dynatrace integration to LD_PRELOAD and support FIPS mode #1041

Migrate dynatrace integration to LD_PRELOAD and support FIPS mode #1041

Uh oh!

Conversation

joushx commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anthonydahanne Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

joushx Nov 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anthonydahanne Nov 13, 2023

Choose a reason for hiding this comment

Uh oh!

anthonydahanne Nov 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anthonydahanne Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

joushx Nov 13, 2023

Choose a reason for hiding this comment

Uh oh!

anthonydahanne Nov 13, 2023

Choose a reason for hiding this comment

Uh oh!

anthonydahanne Nov 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anthonydahanne Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

meibensteiner commented Nov 22, 2023

Uh oh!

dmikusa commented Nov 28, 2023

Uh oh!

TimGerlach commented Dec 13, 2023

Uh oh!

pivotal-david-osullivan commented Dec 15, 2023

Uh oh!

anthonydahanne commented Dec 19, 2023

Uh oh!

joushx commented Dec 20, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joushx commented Dec 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

joushx commented Oct 31, 2023 •

edited

Loading

linux-foundation-easycla bot commented Oct 31, 2023 •

edited

Loading

joushx Nov 13, 2023 •

edited

Loading

anthonydahanne Nov 10, 2023 •

edited

Loading

anthonydahanne Nov 10, 2023 •

edited

Loading