-
Notifications
You must be signed in to change notification settings - Fork 228
Add jorbaum as System Logging and Metrics reviewer #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chombium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorbaum you've added yourself as an approver. Please adjust the changes and add yourself as a reviwer, otherwise LGTM, you are pretty active in the Logging and Metrics Team.
|
Argh.. sorry for that. Fixed it now. |
dfcd4e4 to
24a7cfe
Compare
beyhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jorbaum,
thank you for this pr and the interest to help. Could you please add yourself also to the contributors list in https://github.com/cloudfoundry/community/blob/main/orgs/contributors.yml.
|
@beyhan thanks for reviewing.
Did so. |
chombium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
we don't have more than four approval in this area, which means that one approval from an approver is enough. |
Motivation
Adding me as a code reviewer should help maintain project quality and stability. I’m part of the SAP CF‑Loggregator team; reviews deepen my technical understanding, and I’m committed to sharing knowledge across the team.
Contributions are listed in following gist: https://gist.github.com/jorbaum/ded1ccece12dc5fa970e4e996b8db132