Skip to content

Conversation

@jorbaum
Copy link
Contributor

@jorbaum jorbaum commented Oct 24, 2025

Motivation

Adding me as a code reviewer should help maintain project quality and stability. I’m part of the SAP CF‑Loggregator team; reviews deepen my technical understanding, and I’m committed to sharing knowledge across the team.

Contributions are listed in following gist: https://gist.github.com/jorbaum/ded1ccece12dc5fa970e4e996b8db132

Copy link
Contributor

@chombium chombium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorbaum you've added yourself as an approver. Please adjust the changes and add yourself as a reviwer, otherwise LGTM, you are pretty active in the Logging and Metrics Team.

@jorbaum
Copy link
Contributor Author

jorbaum commented Oct 27, 2025

Argh.. sorry for that.

Fixed it now.

@jorbaum jorbaum force-pushed the jorbaum-foundation branch from dfcd4e4 to 24a7cfe Compare October 27, 2025 08:20
Copy link
Member

@beyhan beyhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jorbaum,

thank you for this pr and the interest to help. Could you please add yourself also to the contributors list in https://github.com/cloudfoundry/community/blob/main/orgs/contributors.yml.

@jorbaum
Copy link
Contributor Author

jorbaum commented Oct 27, 2025

@beyhan thanks for reviewing.

Could you please add yourself also to the contributors list

Did so.

Copy link
Contributor

@chombium chombium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@beyhan
Copy link
Member

beyhan commented Oct 28, 2025

we don't have more than four approval in this area, which means that one approval from an approver is enough.

@rkoster rkoster merged commit d063d29 into cloudfoundry:main Oct 30, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CF Community Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants