Tighten the semantics of POST /v3/service_plans/:guid/visibility #4609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow POST only when type = organization. Otherwise fail with 422 Unprocessable Entity. - Ensure the target plan already has visibility type organization. If the plan’s visibility type is not organization, the request fails with 422 Unprocessable Entity.
johha
reviewed
Nov 11, 2025
| end | ||
|
|
||
| def update(service_plan, message, append_organizations: false) | ||
| type = message.type |
Contributor
There was a problem hiding this comment.
maybe there is a better name for this?
johha
requested changes
Nov 11, 2025
Comment on lines
+81
to
87
| def visibility_type_org?(service_plan) | ||
| service_plan.visibility_type == VCAP::CloudController::ServicePlanVisibilityTypes::ORGANIZATION | ||
| end | ||
|
|
||
| def org?(type) | ||
| type == VCAP::CloudController::ServicePlanVisibilityTypes::ORGANIZATION | ||
| end |
Contributor
There was a problem hiding this comment.
Can we combine this into a single method and use the same pattern for visibility_type_space?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSTonly whentype = organization. Otherwise fail with422 Unprocessable Entity.organization. If the plan’s visibility type is notorganization, the request fails with422 Unprocessable Entity.Fixes #4606
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests