Implement service instances and plans creation and update #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikusa
requested changes
Jul 13, 2022
Contributor
dmikusa
left a comment
dmikusa
left a comment
There was a problem hiding this comment.
I took my first pass through this, and it looks good. There are no integration tests though. I'd like to see some basic coverage of the functionality in integration tests. It's one thing to test with mock responses, but we want to have test coverage that interacts with an actual CF environment too.
I know writing and running integration tests is not trivial. If you are able to put the tests together, I can run them in one of our labs.
IvanBorislavovDimitrov
force-pushed
the
v3-services
branch
from
d19b700 to
f8ba9ed
Compare
Contributor
Author
|
Hi @dmikusa-pivotal, I've added the integration tests, could you please check and run them. I've only tested tested the newly written tests. |
Contributor
|
Thanks. I'll run these this afternoon and get back to you with feedback. |
Contributor
|
Tests runs are passing. Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement missing v3 methods https://v3-apidocs.cloudfoundry.org/version/3.118.0/#service-instances:
Create service instance
Update service instance
Delete service instance
Get service instance
Update service plan visibility